From kde-commits Mon Nov 30 22:53:12 2009 From: David Faure Date: Mon, 30 Nov 2009 22:53:12 +0000 To: kde-commits Subject: Re: KDE/kdelibs/kdecore/sonnet Message-Id: <200911302353.12996.faure () kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=125962165126751 On Monday 30 November 2009, Zack Rusin wrote: > SVN commit 1056377 by zack: > > sonnet: rewrite text segmentation algorithm > > since its creation sonnet was broken with indic, asian, arabic and > a lot of other languages that didn't use english-like alphabets. > this commit removes the custom text segmentation algorithm and replaces > it with a proper unicode tr29-11 algorithm found in qtextboundaryfinder > and hopefully makes sonnet work with all languages in the world. let me > know if causes any regressions. Well, that's what unittests are for ;-) It seems your changes introduce a regression, because sonnet/tests/test_core uses 100% CPU for a very very long time and never terminates. -- David Faure, faure@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).