[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/akonadi/libakonadi
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2007-06-14 22:01:09
Message-ID: 200706150001.13477.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Thursday 14 June 2007, Allen Winter wrote:
> On Wednesday 13 June 2007 4:19:34 am David Faure wrote:
> > On Tuesday 12 June 2007, Allen Winter wrote:
> > > On Tuesday 12 June 2007 3:16:03 pm Christian Ehrlicher wrote:
> > > > SVN commit 674648 by chehrlic:
> > > > 
> > > > remove var name like discussed -> fix compile error
> > > > 
> > > I don't understand why this change is needed.
> > 
> > Because Q_UNUSED() requires the type to be fully defined with MSVC,
> > while gcc is happy to compile that line even when the type of the variable
> > is only a forward declaration. Yeah, MSVC sucks.
> > 
> So, how about we simply replace the 'class Item' with 'include <libakonadi/item.h>" ??
> Then we don't have the forward declaration to confuse MSVC.
> 
> I'd prefer that solution.

That solution raises the number of header inter-dependencies (and slightly increase compile time).
We forward-declare for a reason :-)

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]