[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/akonadi/libakonadi
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-06-14 17:01:59
Message-ID: 200706141902.07969.thiago () kde ! org
[Download RAW message or body]


Allen Winter wrote:
>> Because Q_UNUSED() requires the type to be fully defined with MSVC,
>> while gcc is happy to compile that line even when the type of the
>> variable is only a forward declaration. Yeah, MSVC sucks.
>
>So, how about we simply replace the 'class Item' with 'include
> <libakonadi/item.h>" ?? Then we don't have the forward declaration to
> confuse MSVC.
>
>I'd prefer that solution.

Why not use mine, which doesn't require neither the header nor Q_UNUSED?

Or Volker's solution: de-inline.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]