[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/akonadi/libakonadi
From:       Allen Winter <winter () kde ! org>
Date:       2007-06-14 22:43:39
Message-ID: 200706141843.40819.winter () kde ! org
[Download RAW message or body]

On Thursday 14 June 2007 6:01:09 pm David Faure wrote:
> On Thursday 14 June 2007, Allen Winter wrote:
> > On Wednesday 13 June 2007 4:19:34 am David Faure wrote:
> > > On Tuesday 12 June 2007, Allen Winter wrote:
> > > > On Tuesday 12 June 2007 3:16:03 pm Christian Ehrlicher wrote:
> > > > > SVN commit 674648 by chehrlic:
> > > > > 
> > > > > remove var name like discussed -> fix compile error
> > > > > 
> > > > I don't understand why this change is needed.
> > > 
> > > Because Q_UNUSED() requires the type to be fully defined with MSVC,
> > > while gcc is happy to compile that line even when the type of the variable
> > > is only a forward declaration. Yeah, MSVC sucks.
> > > 
> > So, how about we simply replace the 'class Item' with 'include <libakonadi/item.h>" ??
> > Then we don't have the forward declaration to confuse MSVC.
> > 
> > I'd prefer that solution.
> 
> That solution raises the number of header inter-dependencies (and slightly increase compile time).
> We forward-declare for a reason :-)
> 

Right.
But we also write doxygen comments for a reason.

So, we solved it by removing the inline code.
Which is probably the correct solution anyhow.

Christian, hopefully the code still compiles with MSVC??

-Allen
[prev in list] [next in list] [prev in thread] [next in thread]