[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml
From:       Stephan Kulow <coolo () kde ! org>
Date:       2005-04-08 16:09:35
Message-ID: 200504081809.36452.coolo () kde ! org
[Download RAW message or body]

Am Freitag 08 April 2005 16:16 schrieb Tobias Anton:
> When looking at the source, I think that my patch is equivalent to yours.
> But since I have no test case and no testing environment ready, I sticked
> to commenting only. Sorry for criticizing your coding style in general - it
> should have addressed the backward goto only.
>
> Shall I commit the patch attached to my previous mail?
Does it fix anything?  No. Does it break something? Yes, either intendation
or cvs annotate. So the answer is pretty clear to me: no, don't commit.

Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]