From kde-commits Fri Apr 08 16:09:35 2005 From: Stephan Kulow Date: Fri, 08 Apr 2005 16:09:35 +0000 To: kde-commits Subject: Re: kdelibs/khtml Message-Id: <200504081809.36452.coolo () kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=111298913127323 Am Freitag 08 April 2005 16:16 schrieb Tobias Anton: > When looking at the source, I think that my patch is equivalent to yours. > But since I have no test case and no testing environment ready, I sticked > to commenting only. Sorry for criticizing your coding style in general - it > should have addressed the backward goto only. > > Shall I commit the patch attached to my previous mail? Does it fix anything? No. Does it break something? Yes, either intendation or cvs annotate. So the answer is pretty clear to me: no, don't commit. Greetings, Stephan