[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml
From:       Tobias Anton <tobias.anton () esc-electronics ! de>
Date:       2005-04-08 14:16:26
Message-ID: 200504081616.26038.tobias.anton () esc-electronics ! de
[Download RAW message or body]

Am Freitag, 8. April 2005 14:56 schrieb Lubos Lunak:

> > Comparing your backward goto to a loop, I don't see any advantage of the
> > backward goto. The main disadvantage of the backward goto: The exit
> > condition is not clear, whereas a loop would make it clear.
>
>  Maybe if the code was written with a loop in mind, but the JPEG loader is
> written as linear code that just needs to go back in one place. I even
> tried to make it a loop first, but after getting it wrong two times I
> simply gave up (I did the mistake of trying to use a flag to bail out
> instead of the other way around, and that was pretty non-trivial).

When looking at the source, I think that my patch is equivalent to yours. But 
since I have no test case and no testing environment ready, I sticked to 
commenting only. Sorry for criticizing your coding style in general - it 
should have addressed the backward goto only.

Shall I commit the patch attached to my previous mail?


Cheers
-- Tobias
[prev in list] [next in list] [prev in thread] [next in thread]