[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: ARTS_1_1_BRANCH: arts/flow
From:       Matthias Kretz <kretz () kde ! org>
Date:       2003-07-31 22:36:40
[Download RAW message or body]


On Friday August 1 2003 00:30, George Staikos wrote:
> On Thursday 31 July 2003 18:23, Matthias Kretz wrote:
> > On Friday August 1 2003 00:20, George Staikos wrote:
> > > CVS commit by staikos:
> > >
> > > backport cpu usage fix
> >
> > Uhm, I don't feel comfortable with this. This is not a bugfix, and it's
> > definetly not bugfree. I know at least one way my change can break code -
> > not any existing code I know of but anyway.
>
>   using 3% cpu is a bug.

Well, it's inefficient code for the task it's doing (which most of the time is 
nothing).

>   If it isn't a good patch, then it shouldn't have 
> gone in either branch and should be reverted from both.

Allright revert it in both, I've just realized the problem after I committed 
it. I've already written a fix for the problem but haven't gotten to testing 
it yet.

Also I'm undecided whether it would be better to split the functionality into 
two separate modules, one doing the volume control, the other doing the 
volume meter calculation. It would be a lot cleaner but it wouldn't be 
behaviour compatible.

-- 
C'ya
        Matthias
________________________________________________________
Matthias Kretz (Germany)                          <><
http://Vir.homeip.net/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]