[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: ARTS_1_1_BRANCH: arts/flow
From:       George Staikos <staikos () kde ! org>
Date:       2003-07-31 22:54:40
[Download RAW message or body]

On Thursday 31 July 2003 18:36, Matthias Kretz wrote:
> >   using 3% cpu is a bug.
>
> Well, it's inefficient code for the task it's doing (which most of the time
> is nothing).

  Inefficiency, IMHO, is a bug in such proportion.

> >   If it isn't a good patch, then it shouldn't have
> > gone in either branch and should be reverted from both.
>
> Allright revert it in both, I've just realized the problem after I
> committed it. I've already written a fix for the problem but haven't gotten
> to testing it yet.

  Ok.

> Also I'm undecided whether it would be better to split the functionality
> into two separate modules, one doing the volume control, the other doing
> the volume meter calculation. It would be a lot cleaner but it wouldn't be
> behaviour compatible.

   I wish I could help you here, but I have no clue. :)

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

[prev in list] [next in list] [prev in thread] [next in thread]