--Boundary-02=_4nZK/V1bJhM7V1o
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday August 1 2003 00:30, George Staikos wrote:
> On Thursday 31 July 2003 18:23, Matthias Kretz wrote:
> > On Friday August 1 2003 00:20, George Staikos wrote:
> > > CVS commit by staikos:
> > >
> > > backport cpu usage fix
> >
> > Uhm, I don't feel comfortable with this. This is not a bugfix, and it's
> > definetly not bugfree. I know at least one way my change can break code=
 -
> > not any existing code I know of but anyway.
>
>   using 3% cpu is a bug.

Well, it's inefficient code for the task it's doing (which most of the time=
 is=20
nothing).

>   If it isn't a good patch, then it shouldn't have=20
> gone in either branch and should be reverted from both.

Allright revert it in both, I've just realized the problem after I committe=
d=20
it. I've already written a fix for the problem but haven't gotten to testin=
g=20
it yet.

Also I'm undecided whether it would be better to split the functionality in=
to=20
two separate modules, one doing the volume control, the other doing the=20
volume meter calculation. It would be a lot cleaner but it wouldn't be=20
behaviour compatible.

=2D-=20
C'ya
        Matthias
________________________________________________________
Matthias Kretz (Germany)                          <><
http://Vir.homeip.net/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

--Boundary-02=_4nZK/V1bJhM7V1o
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA/KZn4yg4WnCj6OIoRAhVaAJ9A2l3/vlluqnCM1/3l/G/FuY5oiQCfZE5K
9tXC3WJdGMl5id8GH5SVr7U=
=XjMM
-----END PGP SIGNATURE-----

--Boundary-02=_4nZK/V1bJhM7V1o--