[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
From: Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date: 2014-01-22 21:24:50
Message-ID: 20140122212450.3955.44934 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 22, 2014, 9:08 a.m., Alex Merry wrote:
> > This seems sensible to me; however, I do wonder if ECM should also provide an \
> > ecm_mark_gui_executable function as well (I'm thinking of the case where most of \
> > the tests should be non-gui, but a handful want to display widgets).
>
> Aleix Pol Gonzalez wrote:
> Well, we can't change the default, can we?
>
> Alex Merry wrote:
> I don't understand what you mean.
>
> Aleix Pol Gonzalez wrote:
> If we have a /mark as non gui/ function is because executables are /gui \
> executables/ by default. Having an ecm_mark_gui_executable() would make this weird \
> I'd say.
> (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just \
> a limitation on Windows (and Android))
> Alex Merry wrote:
> We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in \
> KDECMakeSettings.cmake. CMake documentation is unforthcoming about the default in \
> the absence of that setting, but I think it is off.
A "non-GUI" (console) executable can still display widgets.
- Nicolás
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/#review48009
-----------------------------------------------------------
On Jan. 22, 2014, 11:54 a.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115211/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 11:54 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Mark target created by ecm_add_test as non GUI by default
>
> This behaviour can be overriden by passing the GUI flag to the command
>
>
> Diffs
> -----
>
> modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e
>
> Diff: https://git.reviewboard.kde.org/r/115211/diff/
>
>
> Testing
> -------
>
> Oketeta unit tests wouldn't build on windows before this commit, now they do
>
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115211/">https://git.reviewboard.kde.org/r/115211/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 22nd, 2014, 9:08 a.m. ART, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This seems sensible to me; however, I do wonder if ECM should also \
provide an ecm_mark_gui_executable function as well (I'm thinking of the case \
where most of the tests should be non-gui, but a handful want to display \
widgets).</pre> </blockquote>
<p>On January 22nd, 2014, 9:09 a.m. ART, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, we can't \
change the default, can we?</pre> </blockquote>
<p>On January 22nd, 2014, 9:28 a.m. ART, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand \
what you mean.</pre> </blockquote>
<p>On January 22nd, 2014, 9:37 a.m. ART, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we have a /mark as \
non gui/ function is because executables are /gui executables/ by default. Having an \
ecm_mark_gui_executable() would make this weird I'd say.
(TBH, it seems to me cmake shouldn't know about that at all, but I take it as \
just a limitation on Windows (and Android))</pre> </blockquote>
<p>On January 22nd, 2014, 9:54 a.m. ART, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have it because we \
call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake. CMake documentation \
is unforthcoming about the default in the absence of that setting, but I think it is \
off.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A "non-GUI" \
(console) executable can still display widgets.</pre> <br />
<p>- Nicolás</p>
<br />
<p>On January 22nd, 2014, 11:54 a.m. ART, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 11:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mark target created by ecm_add_test as non GUI by default
This behaviour can be overriden by passing the GUI flag to the command</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Oketeta unit tests wouldn't build on windows before this commit, now \
they do</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddTests.cmake <span style="color: \
grey">(ff97d764d58c781d6c37dd08c8cb175ce500962e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115211/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic