This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ |
On January 22nd, 2014, 9:08 a.m. ART, Alex Merry wrote:
This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets).On January 22nd, 2014, 9:09 a.m. ART, Aleix Pol Gonzalez wrote:
Well, we can't change the default, can we?On January 22nd, 2014, 9:28 a.m. ART, Alex Merry wrote:
I don't understand what you mean.On January 22nd, 2014, 9:37 a.m. ART, Aleix Pol Gonzalez wrote:
If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say. (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android))On January 22nd, 2014, 9:54 a.m. ART, Alex Merry wrote:
We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake. CMake documentation is unforthcoming about the default in the absence of that setting, but I think it is off.
A "non-GUI" (console) executable can still display widgets.
- Nicolás
On January 22nd, 2014, 11:54 a.m. ART, Alexander Richardson wrote:
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
By Alexander Richardson.
Updated Jan. 22, 2014, 11:54 a.m.
Repository:
extra-cmake-modules
Description
Testing
Diffs
|