--===============5228413818780841458== Content-Type: multipart/alternative; boundary="===============5602878209959612465==" --===============5602878209959612465== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Jan. 22, 2014, 9:08 a.m., Alex Merry wrote: > > This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). > > Aleix Pol Gonzalez wrote: > Well, we can't change the default, can we? > > Alex Merry wrote: > I don't understand what you mean. > > Aleix Pol Gonzalez wrote: > If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say. > > (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android)) > > Alex Merry wrote: > We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake. CMake documentation is unforthcoming about the default in the absence of that setting, but I think it is off. A "non-GUI" (console) executable can still display widgets. - Nicolás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 ----------------------------------------------------------- On Jan. 22, 2014, 11:54 a.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115211/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 11:54 a.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Mark target created by ecm_add_test as non GUI by default > > This behaviour can be overriden by passing the GUI flag to the command > > > Diffs > ----- > > modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e > > Diff: https://git.reviewboard.kde.org/r/115211/diff/ > > > Testing > ------- > > Oketeta unit tests wouldn't build on windows before this commit, now they do > > > Thanks, > > Alexander Richardson > > --===============5602878209959612465== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/

On January 22nd, 2014, 9:08 a.m. ART, Alex Merry wrote:

This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets).

On January 22nd, 2014, 9:09 a.m. ART, Aleix Pol Gonzalez wrote:

Well, we can't change the default, can we?

On January 22nd, 2014, 9:28 a.m. ART, Alex Merry wrote:

I don't understand what you mean.

On January 22nd, 2014, 9:37 a.m. ART, Aleix Pol Gonzalez wrote:

If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say.

(TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android))

On January 22nd, 2014, 9:54 a.m. ART, Alex Merry wrote:

We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake.  CMake documentation is unforthcoming about the default in the absence of that setting, but I think it is off.
A "non-GUI" (console) executable can still display widgets.

- Nicolás


On January 22nd, 2014, 11:54 a.m. ART, Alexander Richardson wrote:

Review request for Build System, Extra Cmake Modules and KDE Frameworks.
By Alexander Richardson.

Updated Jan. 22, 2014, 11:54 a.m.

Repository: extra-cmake-modules

Description 

Mark target created by ecm_add_test as non GUI by default

This behaviour can be overriden by passing the GUI flag to the command

Testing 

Oketeta unit tests wouldn't build on windows before this commit, now they do

Diffs

  • modules/ECMAddTests.cmake (ff97d764d58c781d6c37dd08c8cb175ce500962e)

View Diff
--===============5602878209959612465==-- --===============5228413818780841458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============5228413818780841458==--