[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: PyKF5 bindings generator improvements out for review.
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2017-01-29 21:09:52
Message-ID: CAHAc2jeAAsWN_z4A51UE5zSadKjapeNc0AaYER+KAUZKeUBSLA () mail ! gmail ! com
[Download RAW message or body]

OK, let's start small:
https://github.com/ShaheedHaque/extra-cmake-modules/pull/2.

Please review...

On 29 January 2017 at 17:12, Stephen Kelly <steveire@gmail.com> wrote:

> Shaheed Haque wrote:
>
> > Rewrite? It think its more a case of forking making things diverge (if
> you
> > look, a lot of the changes are formatting, name changes and comments,
> > though I accept that does make for a lot of noise). I have tried VERY
> hard
> > to keep the good changes form both sides...and yes, there ARE a
> reasonable
> > number of actual changes too.
> >
> > Anyway, I was under the impression a squashed single commit was
> preferred,
> > but I can look to pull things out again. I would prefer to work the
> > reviews via github's Pull Requests, is that still OK?
>
> Yep, sounds good to me!
>
> Thanks,
>
> Steve.
>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>OK, let&#39;s start small: <a \
href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/2">https://github.com/ShaheedHaque/extra-cmake-modules/pull/2</a>.<br><br></div>Please \
review...<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 29 \
January 2017 at 17:12, Stephen Kelly <span dir="ltr">&lt;<a \
href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">Shaheed Haque wrote:<br> <br>
&gt; Rewrite? It think its more a case of forking making things diverge (if you<br>
&gt; look, a lot of the changes are formatting, name changes and comments,<br>
&gt; though I accept that does make for a lot of noise). I have tried VERY hard<br>
&gt; to keep the good changes form both sides...and yes, there ARE a reasonable<br>
&gt; number of actual changes too.<br>
&gt;<br>
&gt; Anyway, I was under the impression a squashed single commit was preferred,<br>
&gt; but I can look to pull things out again. I would prefer to work the<br>
&gt; reviews via github&#39;s Pull Requests, is that still OK?<br>
<br>
</span>Yep, sounds good to me!<br>
<br>
Thanks,<br>
<br>
Steve.<br>
<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]