[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: PyKF5 bindings generator improvements out for review.
From:       Stephen Kelly <steveire () gmail ! com>
Date:       2017-01-29 17:12:59
Message-ID: 588e229c.496f1c0a.52e7f.abcc () mx ! google ! com
[Download RAW message or body]

Shaheed Haque wrote:

> Rewrite? It think its more a case of forking making things diverge (if you
> look, a lot of the changes are formatting, name changes and comments,
> though I accept that does make for a lot of noise). I have tried VERY hard
> to keep the good changes form both sides...and yes, there ARE a reasonable
> number of actual changes too.
> 
> Anyway, I was under the impression a squashed single commit was preferred,
> but I can look to pull things out again. I would prefer to work the
> reviews via github's Pull Requests, is that still OK?

Yep, sounds good to me!

Thanks,

Steve.

[prev in list] [next in list] [prev in thread] [next in thread]