[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: url issue in bodega with ssh
From:       Giorgos Tsiapaliokas <terietor () gmail ! com>
Date:       2013-08-20 14:17:09
Message-ID: CAODYyLbLNduzPdZUCbQLjeq707i74PgxUUWxmU+J6NiC8XmR_g () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 20 August 2013 16:29, Marco Martin <notmart@gmail.com> wrote:

> Hi all,
>
> found a last small potential blocker for pa4:
> bodega-client is now set for using ssh by default, by using as server
> https://addons.makeplaylive.com:3443
>
> but the server tells to take the images from something like
> http://addons.makeplaylive.com:3443/foo
>
> the problem is in lib/utils.js line 42
> module.exports.findImagePaths
> var serverUrl = 'http://' + req.header('host');
>
> that hardcodes http (and i don't think with haproxy is possible to really
> know
> what it is?)
>
> right now i changed it to https in the running server, so active-addons
> will
> work fine in pa4, but a proper solution must be found.
>

in app.js lines 90-99 the server checks for https. So we could
add a app.isHTTPS and in lib/utils.js to act appropriate based on if
app.isHTTPS is true or false. No?

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On 20 \
August 2013 16:29, Marco Martin <span dir="ltr">&lt;<a \
href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Hi all,<br> <br>
found a last small potential blocker for pa4:<br>
bodega-client is now set for using ssh by default, by using as server<br>
<a href="https://addons.makeplaylive.com:3443" \
target="_blank">https://addons.makeplaylive.com:3443</a><br> <br>
but the server tells to take the images from something like<br>
<a href="http://addons.makeplaylive.com:3443/foo" \
target="_blank">http://addons.makeplaylive.com:3443/foo</a><br> <br>
the problem is in lib/utils.js line 42<br>
module.exports.findImagePaths<br>
var serverUrl = &#39;http://&#39; + req.header(&#39;host&#39;);<br>
<br>
that hardcodes http (and i don&#39;t think with haproxy is possible to really \
know<br> what it is?)<br>
<br>
right now i changed it to https in the running server, so active-addons will<br>
work fine in pa4, but a proper solution must be \
found.<br></blockquote><div><br></div><div>in app.js lines 90-99 the server checks \
for https. So we could</div><div>add a app.isHTTPS and in lib/utils.js to act \
appropriate based on if</div> <div>app.isHTTPS is true or false. No? \
</div></div><div><br></div>-- <br><div dir="ltr">Giorgos Tsiapaliokas \
(terietor)<br><br><a href="http://terietor.org" \
target="_blank">terietor.org</a></div> </div></div>



_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active


[prev in list] [next in list] [prev in thread] [next in thread]