On 20 August 2013 16:29, Marco Martin <notmart@gmail.com> wrote:
Hi all,

found a last small potential blocker for pa4:
bodega-client is now set for using ssh by default, by using as server
https://addons.makeplaylive.com:3443

but the server tells to take the images from something like
http://addons.makeplaylive.com:3443/foo

the problem is in lib/utils.js line 42
module.exports.findImagePaths
var serverUrl = 'http://' + req.header('host');

that hardcodes http (and i don't think with haproxy is possible to really know
what it is?)

right now i changed it to https in the running server, so active-addons will
work fine in pa4, but a proper solution must be found.

in app.js lines 90-99 the server checks for https. So we could
add a app.isHTTPS and in lib/utils.js to act appropriate based on if
app.isHTTPS is true or false. No? 

--
Giorgos Tsiapaliokas (terietor)

terietor.org