--===============2841159543002427636==
Content-Type: multipart/alternative; boundary=047d7bf18758605b0204e461b67c

--047d7bf18758605b0204e461b67c
Content-Type: text/plain; charset=ISO-8859-1

On 20 August 2013 16:29, Marco Martin <notmart@gmail.com> wrote:

> Hi all,
>
> found a last small potential blocker for pa4:
> bodega-client is now set for using ssh by default, by using as server
> https://addons.makeplaylive.com:3443
>
> but the server tells to take the images from something like
> http://addons.makeplaylive.com:3443/foo
>
> the problem is in lib/utils.js line 42
> module.exports.findImagePaths
> var serverUrl = 'http://' + req.header('host');
>
> that hardcodes http (and i don't think with haproxy is possible to really
> know
> what it is?)
>
> right now i changed it to https in the running server, so active-addons
> will
> work fine in pa4, but a proper solution must be found.
>

in app.js lines 90-99 the server checks for https. So we could
add a app.isHTTPS and in lib/utils.js to act appropriate based on if
app.isHTTPS is true or false. No?

-- 
Giorgos Tsiapaliokas (terietor)

terietor.org

--047d7bf18758605b0204e461b67c
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><br><div class=3D"gmail=
_quote">On 20 August 2013 16:29, Marco Martin <span dir=3D"ltr">&lt;<a href=
=3D"mailto:notmart@gmail.com" target=3D"_blank">notmart@gmail.com</a>&gt;</=
span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Hi all,<br>
<br>
found a last small potential blocker for pa4:<br>
bodega-client is now set for using ssh by default, by using as server<br>
<a href=3D"https://addons.makeplaylive.com:3443" target=3D"_blank">https://=
addons.makeplaylive.com:3443</a><br>
<br>
but the server tells to take the images from something like<br>
<a href=3D"http://addons.makeplaylive.com:3443/foo" target=3D"_blank">http:=
//addons.makeplaylive.com:3443/foo</a><br>
<br>
the problem is in lib/utils.js line 42<br>
module.exports.findImagePaths<br>
var serverUrl =3D &#39;http://&#39; + req.header(&#39;host&#39;);<br>
<br>
that hardcodes http (and i don&#39;t think with haproxy is possible to real=
ly know<br>
what it is?)<br>
<br>
right now i changed it to https in the running server, so active-addons wil=
l<br>
work fine in pa4, but a proper solution must be found.<br></blockquote><div=
><br></div><div>in app.js lines 90-99 the server checks for https. So we co=
uld</div><div>add a app.isHTTPS and in lib/utils.js to act appropriate base=
d on if</div>
<div>app.isHTTPS is true or false. No?=A0</div></div><div><br></div>-- <br>=
<div dir=3D"ltr">Giorgos=A0Tsiapaliokas=A0(terietor)<br><br><a href=3D"http=
://terietor.org" target=3D"_blank">terietor.org</a></div>
</div></div>

--047d7bf18758605b0204e461b67c--

--===============2841159543002427636==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

--===============2841159543002427636==--