'Re: Review Request 126678: Fix bug #356998 - previews are not updated after undo operations.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 126678: Fix bug #356998 - previews are not updated after undo operations.
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2016-01-10 22:42:06
Message-ID: 20160110224206.23702.40225 () mimi ! kde ! org
[Download RAW message or body]

--===============5913426469220705551==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126678/#review90860
-----------------------------------------------------------

Do you think this could be done without adding a new method, by making \
implementations of AbstractDocumentEditor::setImage and applyTransformation emit the \
modified() signal?

- Aurélien Gâteau

On jan. 8, 2016, 12:40 après-midi, Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126678/
> -----------------------------------------------------------
> 
> (Updated jan. 8, 2016, 12:40 après-midi)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This fixes bug #356998 - previews are not updated after undo operations.
> 
> 
> Diffs
> -----
> 
> lib/crop/cropimageoperation.cpp 7822d1e 
> lib/document/document.h 550a6d2 
> lib/document/document.cpp 0ed83cf 
> lib/redeyereduction/redeyereductionimageoperation.cpp 9e5e930 
> lib/resize/resizeimageoperation.cpp a31c64c 
> 
> Diff: https://git.reviewboard.kde.org/r/126678/diff/
> 
> 
> Testing
> -------
> 
> Ran gwenview with the sample images and tested that undo/etc. update the preview.
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
> 

--===============5913426469220705551==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126678/">https://git.reviewboard.kde.org/r/126678/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do \
you think this could be done without adding a new method, by making implementations \
of AbstractDocumentEditor::setImage and applyTransformation emit the modified() \
signal?</p></pre>  <br />

<p>- Aurélien Gâteau</p>

<br />
<p>On janvier 8th, 2016, 12:40 après-midi CET, Shlomi Fish wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Shlomi Fish.</div>

<p style="color: grey;"><i>Updated jan. 8, 2016, 12:40 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes bug #356998 - previews are not updated \
after undo operations.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran gwenview with the sample images and tested that \
undo/etc. update the preview.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/crop/cropimageoperation.cpp <span style="color: grey">(7822d1e)</span></li>

 <li>lib/document/document.h <span style="color: grey">(550a6d2)</span></li>

 <li>lib/document/document.cpp <span style="color: grey">(0ed83cf)</span></li>

 <li>lib/redeyereduction/redeyereductionimageoperation.cpp <span style="color: \
grey">(9e5e930)</span></li>

 <li>lib/resize/resizeimageoperation.cpp <span style="color: \
grey">(a31c64c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126678/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5913426469220705551==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 