[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Review Request 126678: Fix bug #356998 - previews are not updated after undo operations.
From: "Shlomi Fish" <shlomif () iglu ! org ! il>
Date: 2016-01-08 11:40:53
Message-ID: 20160108114053.6499.93931 () mimi ! kde ! org
[Download RAW message or body]
--===============7338630388563965487==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126678/
-----------------------------------------------------------
Review request for Gwenview.
Repository: gwenview
Description
-------
This fixes bug #356998 - previews are not updated after undo operations.
Diffs
-----
lib/crop/cropimageoperation.cpp 7822d1e
lib/document/document.h 550a6d2
lib/document/document.cpp 0ed83cf
lib/redeyereduction/redeyereductionimageoperation.cpp 9e5e930
lib/resize/resizeimageoperation.cpp a31c64c
Diff: https://git.reviewboard.kde.org/r/126678/diff/
Testing
-------
Ran gwenview with the sample images and tested that undo/etc. update the preview.
Thanks,
Shlomi Fish
--===============7338630388563965487==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126678/">https://git.reviewboard.kde.org/r/126678/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Shlomi Fish.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes bug #356998 - previews are not updated \
after undo operations.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran gwenview with the sample images and tested that \
undo/etc. update the preview.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/crop/cropimageoperation.cpp <span style="color: grey">(7822d1e)</span></li>
<li>lib/document/document.h <span style="color: grey">(550a6d2)</span></li>
<li>lib/document/document.cpp <span style="color: grey">(0ed83cf)</span></li>
<li>lib/redeyereduction/redeyereductionimageoperation.cpp <span style="color: \
grey">(9e5e930)</span></li>
<li>lib/resize/resizeimageoperation.cpp <span style="color: \
grey">(a31c64c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126678/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7338630388563965487==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic