--===============8379571567603380402== Content-Type: multipart/alternative; boundary="===============5913426469220705551==" --===============5913426469220705551== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126678/#review90860 ----------------------------------------------------------- Do you think this could be done without adding a new method, by making implementations of AbstractDocumentEditor::setImage and applyTransformation emit the modified() signal? - Aurélien Gâteau On jan. 8, 2016, 12:40 après-midi, Shlomi Fish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126678/ > ----------------------------------------------------------- > > (Updated jan. 8, 2016, 12:40 après-midi) > > > Review request for Gwenview. > > > Repository: gwenview > > > Description > ------- > > This fixes bug #356998 - previews are not updated after undo operations. > > > Diffs > ----- > > lib/crop/cropimageoperation.cpp 7822d1e > lib/document/document.h 550a6d2 > lib/document/document.cpp 0ed83cf > lib/redeyereduction/redeyereductionimageoperation.cpp 9e5e930 > lib/resize/resizeimageoperation.cpp a31c64c > > Diff: https://git.reviewboard.kde.org/r/126678/diff/ > > > Testing > ------- > > Ran gwenview with the sample images and tested that undo/etc. update the preview. > > > Thanks, > > Shlomi Fish > > --===============5913426469220705551== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126678/ 

Do you think this could be done without adding a new method, by making implementations of AbstractDocumentEditor::setImage and applyTransformation emit the modified() signal?

- Aurélien Gâteau


On janvier 8th, 2016, 12:40 après-midi CET, Shlomi Fish wrote:

Review request for Gwenview.
By Shlomi Fish.

Updated jan. 8, 2016, 12:40 après-midi

Repository: gwenview

Description 

This fixes bug #356998 - previews are not updated after undo operations.

Testing 

Ran gwenview with the sample images and tested that undo/etc. update the preview.

Diffs

  • lib/crop/cropimageoperation.cpp (7822d1e)
  • lib/document/document.h (550a6d2)
  • lib/document/document.cpp (0ed83cf)
  • lib/redeyereduction/redeyereductionimageoperation.cpp (9e5e930)
  • lib/resize/resizeimageoperation.cpp (a31c64c)

View Diff
--===============5913426469220705551==-- --===============8379571567603380402== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3dlbnZpZXct ZGV2ZWwgbWFpbGluZyBsaXN0Ckd3ZW52aWV3LWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9nd2Vudmlldy1kZXZlbAo= --===============8379571567603380402==--