'Re: Review Request 122983: [gwenview] Make tests optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 122983: [gwenview] Make tests optional
From:       "Andreas Sturmlechner" <andreas.sturmlechner () gmail ! com>
Date:       2015-07-30 11:49:03
Message-ID: 20150730114903.31864.37261 () mimi ! kde ! org
[Download RAW message or body]

--===============1329762999686633118==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122983/
-----------------------------------------------------------

(Updated July 30, 2015, 11:49 a.m.)

Status
------

This change has been discarded.

Review request for Gwenview.

Repository: gwenview

Description
-------

There was already a check performed in tests/auto to conditionally build them if \
Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as \
well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made optional \
as seen in kwin).

Diffs
-----

  CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be 
  tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb 
  tests/auto/CMakeLists.txt 9757a582b9309e30f0c1edc286a541de853fed64 

Diff: https://git.reviewboard.kde.org/r/122983/diff/

Testing
-------

Built with and without tests. I am currently not able to get a success everywhere, \
but the patch doesn't change anything about it.

Also, something to be done about the following? `The dependency target "buildtests" \
of target "check" does not exist.`

Thanks,

Andreas Sturmlechner

--===============1329762999686633118==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122983/">https://git.reviewboard.kde.org/r/122983/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Andreas Sturmlechner.</div>

<p style="color: grey;"><i>Updated July 30, 2015, 11:49 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There was already a check performed in tests/auto to \
conditionally build them if Qt5Test_FOUND - so I moved that up one directory to \
expand it to tests/manual as well. find_package(Qt5Test) is already done in root \
CMakeLists.txt (and made optional as seen in kwin).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built with and without tests. I am currently not able \
to get a success everywhere, but the patch doesn't change anything about it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also, something to be done about the following? <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">The dependency target "buildtests" of target "check" does \
not exist.</code></p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(2d2ab8d5594421cf4539db3e30425b1b11ef14be)</span></li>

 <li>tests/CMakeLists.txt <span style="color: \
grey">(a8a2913ca0fce5f58952373527d838a89f64cdfb)</span></li>

 <li>tests/auto/CMakeLists.txt <span style="color: \
grey">(9757a582b9309e30f0c1edc286a541de853fed64)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122983/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1329762999686633118==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 