[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 122983: [gwenview] Make tests optional
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2015-03-22 16:04:43
Message-ID: 20150322160443.548.14016 () mimi ! kde ! org
[Download RAW message or body]
--===============6980570425461892886==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122983/#review77914
-----------------------------------------------------------
tests/CMakeLists.txt (line 1)
<https://git.reviewboard.kde.org/r/122983/#comment53417>
Instead of doing a `return()` from tests/CMakeLists.txt it would be nicer to \
change the root CMakeLists.txt to wrap the `add_subdirectory(tests)` in a `if \
(Qt5Test_FOUND)` check.
- Aurélien Gâteau
On March 16, 2015, 10:14 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122983/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 10:14 p.m.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> There was already a check performed in tests/auto to conditionally build them if \
> Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as \
> well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made \
> optional as seen in kwin).
>
> Diffs
> -----
>
> CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be
> tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb
> tests/auto/CMakeLists.txt 9757a582b9309e30f0c1edc286a541de853fed64
>
> Diff: https://git.reviewboard.kde.org/r/122983/diff/
>
>
> Testing
> -------
>
> Built with and without tests. I am currently not able to get a success everywhere, \
> but the patch doesn't change anything about it.
> Also, something to be done about the following? `The dependency target "buildtests" \
> of target "check" does not exist.`
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============6980570425461892886==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122983/">https://git.reviewboard.kde.org/r/122983/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122983/diff/1/?file=355348#file355348line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">NOT</span> <span \
class="s">Qt5Test_FOUND</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Instead of doing a <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">return()</code> from tests/CMakeLists.txt it would be nicer to change the \
root CMakeLists.txt to wrap the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">add_subdirectory(tests)</code> in a <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">if (Qt5Test_FOUND)</code> check.</p></pre> </div>
</div>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On March 16th, 2015, 10:14 p.m. CET, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated March 16, 2015, 10:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There was already a check performed in tests/auto to \
conditionally build them if Qt5Test_FOUND - so I moved that up one directory to \
expand it to tests/manual as well. find_package(Qt5Test) is already done in root \
CMakeLists.txt (and made optional as seen in kwin).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built with and without tests. I am currently not able \
to get a success everywhere, but the patch doesn't change anything about it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also, something to be done about the following? <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">The dependency target "buildtests" of target "check" does \
not exist.</code></p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(2d2ab8d5594421cf4539db3e30425b1b11ef14be)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(a8a2913ca0fce5f58952373527d838a89f64cdfb)</span></li>
<li>tests/auto/CMakeLists.txt <span style="color: \
grey">(9757a582b9309e30f0c1edc286a541de853fed64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122983/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6980570425461892886==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic