[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 124416: Do not scale up images smaller than the thumbnail size
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2015-08-14 7:35:42
Message-ID: 20150814073542.3671.51593 () mimi ! kde ! org
[Download RAW message or body]
--===============0558112863177362727==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124416/
-----------------------------------------------------------
(Updated août 14, 2015, 9:35 matin)
Review request for Gwenview.
Changes
-------
Using mOriginalWidth and mOriginalHeight was not a good idea: they are not \
initialized at this point, use originalSize instead. Plus the comparison operator was \
wrong. Still wondering what I was smoking...
Repository: gwenview
Description
-------
When generating thumbnails Gwenview asks the QImageReader to scale at load time if \
possible. Seems like the PNG reader gains support for this recently, resulting in \
Gwenview asking the PNG reader to scale images at load, including small images like \
icons, which gets scaled up to fit the thumbnail square. This is not good since it \
produces blurry thumbnails.
This patch checks if the image is larger than the thumbnail square before asking the \
QImageReader to scale.
Diffs (updated)
-----
lib/thumbnailprovider/thumbnailgenerator.cpp \
54875f5df89530edf3aacbd6c30cf893ce0eb405
Diff: https://git.reviewboard.kde.org/r/124416/diff/
Testing
-------
Tested with small and large images.
Thanks,
Aurélien Gâteau
--===============0558112863177362727==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124416/">https://git.reviewboard.kde.org/r/124416/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated août 14, 2015, 9:35 matin</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using mOriginalWidth and mOriginalHeight was not a good idea: they are \
not initialized at this point, use originalSize instead. Plus the comparison operator \
was wrong. Still wondering what I was smoking...</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When generating thumbnails Gwenview asks the \
QImageReader to scale at load time if possible. Seems like the PNG reader gains \
support for this recently, resulting in Gwenview asking the PNG reader to scale \
images at load, including small images like icons, which gets scaled up to fit the \
thumbnail square. This is not good since it produces blurry thumbnails.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch checks if the image is larger than the thumbnail square before \
asking the QImageReader to scale.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with small and large images.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(54875f5df89530edf3aacbd6c30cf893ce0eb405)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124416/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0558112863177362727==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic