From gwenview-devel Sun Mar 22 16:04:43 2015 From: =?utf-8?b?QXVyw6lsaWVuIEfDonRlYXU=?= Date: Sun, 22 Mar 2015 16:04:43 +0000 To: gwenview-devel Subject: Re: Review Request 122983: [gwenview] Make tests optional Message-Id: <20150322160443.548.14016 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=gwenview-devel&m=142704029614697 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5006463427264770883==" --===============5006463427264770883== Content-Type: multipart/alternative; boundary="===============6980570425461892886==" --===============6980570425461892886== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122983/#review77914 ----------------------------------------------------------- tests/CMakeLists.txt (line 1) Instead of doing a `return()` from tests/CMakeLists.txt it would be nicer to change the root CMakeLists.txt to wrap the `add_subdirectory(tests)` in a `if (Qt5Test_FOUND)` check. - Aurélien Gâteau On March 16, 2015, 10:14 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122983/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 10:14 p.m.) > > > Review request for Gwenview. > > > Repository: gwenview > > > Description > ------- > > There was already a check performed in tests/auto to conditionally build them if Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made optional as seen in kwin). > > > Diffs > ----- > > CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be > tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb > tests/auto/CMakeLists.txt 9757a582b9309e30f0c1edc286a541de853fed64 > > Diff: https://git.reviewboard.kde.org/r/122983/diff/ > > > Testing > ------- > > Built with and without tests. I am currently not able to get a success everywhere, but the patch doesn't change anything about it. > > Also, something to be done about the following? `The dependency target "buildtests" of target "check" does not exist.` > > > Thanks, > > Andreas Sturmlechner > > --===============6980570425461892886== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122983/

tests/CMakeLists.txt (Diff revision 1)
		1	if(NOT Qt5Test_FOUND)

Instead of doing a return() from tests/CMakeLists.txt it would be nicer to change the root CMakeLists.txt to wrap the add_subdirectory(tests) in a if (Qt5Test_FOUND) check.

- Aurélien Gâteau

On March 16th, 2015, 10:14 p.m. CET, Andreas Sturmlechner wrote:

Review request for Gwenview.

By Andreas Sturmlechner.

Updated March 16, 2015, 10:14 p.m.

Repository: gwenview

Description

There was already a check performed in tests/auto to conditionally build them if Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made optional as seen in kwin).

Testing

Built with and without tests. I am currently not able to get a success everywhere, but the patch doesn't change anything about it.

Also, something to be done about the following? The dependency target "buildtests" of target "check" does not exist.

Diffs

CMakeLists.txt (2d2ab8d5594421cf4539db3e30425b1b11ef14be)
tests/CMakeLists.txt (a8a2913ca0fce5f58952373527d838a89f64cdfb)
tests/auto/CMakeLists.txt (9757a582b9309e30f0c1edc286a541de853fed64)

--===============6980570425461892886==-- --===============5006463427264770883== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3dlbnZpZXct ZGV2ZWwgbWFpbGluZyBsaXN0Ckd3ZW52aWV3LWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9nd2Vudmlldy1kZXZlbAo= --===============5006463427264770883==--