[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 122753: [Krita] add the option to show/hide the title bars of the dockers to the
From: "Moritz Molch" <kde () moritzmolch ! de>
Date: 2015-03-01 12:58:01
Message-ID: 20150301125801.6756.54779 () probe ! kde ! org
[Download RAW message or body]
--===============4295253077820329623==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 28, 2015, 1:42 p.m., Camilla Boemann wrote:
> > shouldn't this feature be in all of of calligra ?
> > that said we are closed for features until 3.0 is released
>
> Friedrich W. H. Kossebau wrote:
> Would agree this should be a feature calligra wide.
>
> WRT featue freeze, if it is nice feature, small code change, and well reviewed, I \
> would be for still letting that in. No rules without reasonable exceptions.
> Not yet looked at the code in detail, though.
>
> Boudewijn Rempt wrote:
> Maybe, maybe not. Calligra apps that use the sidebar instead of dockers probably \
> don't need it. In any case, Krita no longer shares the komain and the mainwindow \
> code with the rest of calligra, so if the rest of calligra wants this feature, it \
> can be implemented -- but there's no need for Moritz to do that.
> Friedrich W. H. Kossebau wrote:
> No need, but would be great :) (Besides, the sidebar is not integrating all the \
> dockers, there are still quite some normal ones also in those apps. And even hiding \
> the titlebar of the sidebar would be nice to have). So Moritz, do you think you \
> could give it a try to also do this patch for the KoMainWindow-based code?
> Boudewijn Rempt wrote:
> If that scratches an itch, why not, but let this be clear: there is absolutely no \
> obligation whatsoever.
Thank you for your replies.
I added the changes to the KoMainWindow and it seems to work very well. I only tested \
with karbon though because compiling takes quite a long time on my 7 year old but \
absolutely silent machine, so I updated the patch with certain reserves because it \
really should be tested with all the depending applications. Kind regards
- Moritz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122753/#review76765
-----------------------------------------------------------
On Feb. 28, 2015, 1:01 p.m., Moritz Molch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122753/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:01 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Inspired by kdenlive, this small patch adds the option to show/hide the titlebars \
> of all dockers to the settings menu.
>
> Diffs
> -----
>
> krita/ui/KisMainWindow.cpp e8c6009
> krita/ui/kis_config.h b6852de
> krita/ui/kis_config.cc a09c7b8
> libs/widgets/KoDockWidgetTitleBar.cpp cf0c722
> krita/krita.action b683185
> krita/krita.rc 0ec0931
> krita/ui/KisMainWindow.h 9cdcce5
>
> Diff: https://git.reviewboard.kde.org/r/122753/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu 14.04
>
>
> Thanks,
>
> Moritz Molch
>
>
--===============4295253077820329623==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122753/">https://git.reviewboard.kde.org/r/122753/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2015, 1:42 p.m. UTC, <b>Camilla \
Boemann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">shouldn't this feature be in all of of calligra ? that \
said we are closed for features until 3.0 is released</p></pre> </blockquote>
<p>On February 28th, 2015, 7:54 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
agree this should be a feature calligra wide.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">WRT \
featue freeze, if it is nice feature, small code change, and well reviewed, I would \
be for still letting that in. No rules without reasonable exceptions.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not yet looked at the code in detail, though.</p></pre> </blockquote>
<p>On February 28th, 2015, 7:58 p.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Maybe, maybe not. Calligra apps that use the sidebar instead of dockers \
probably don't need it. In any case, Krita no longer shares the komain and the \
mainwindow code with the rest of calligra, so if the rest of calligra wants this \
feature, it can be implemented -- but there's no need for Moritz to do \
that.</p></pre> </blockquote>
<p>On February 28th, 2015, 8:23 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No \
need, but would be great :) (Besides, the sidebar is not integrating all the dockers, \
there are still quite some normal ones also in those apps. And even hiding the \
titlebar of the sidebar would be nice to have). So Moritz, do you think you could \
give it a try to also do this patch for the KoMainWindow-based code?</p></pre> \
</blockquote>
<p>On February 28th, 2015, 8:28 p.m. UTC, <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
that scratches an itch, why not, but let this be clear: there is absolutely no \
obligation whatsoever.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank \
you for your replies. I added the changes to the KoMainWindow and it seems to work \
very well. I only tested with karbon though because compiling takes quite a long time \
on my 7 year old but absolutely silent machine, so I updated the patch with certain \
reserves because it really should be tested with all the depending applications. Kind \
regards</p></pre> <br />
<p>- Moritz</p>
<br />
<p>On February 28th, 2015, 1:01 p.m. UTC, Moritz Molch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Moritz Molch.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2015, 1:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Inspired by kdenlive, this small patch adds the option \
to show/hide the titlebars of all dockers to the settings menu.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on Ubuntu 14.04</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/KisMainWindow.cpp <span style="color: grey">(e8c6009)</span></li>
<li>krita/ui/kis_config.h <span style="color: grey">(b6852de)</span></li>
<li>krita/ui/kis_config.cc <span style="color: grey">(a09c7b8)</span></li>
<li>libs/widgets/KoDockWidgetTitleBar.cpp <span style="color: \
grey">(cf0c722)</span></li>
<li>krita/krita.action <span style="color: grey">(b683185)</span></li>
<li>krita/krita.rc <span style="color: grey">(0ec0931)</span></li>
<li>krita/ui/KisMainWindow.h <span style="color: grey">(9cdcce5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122753/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4295253077820329623==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic