This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122753/

On February 28th, 2015, 1:42 p.m. UTC, Camilla Boemann wrote:

shouldn't this feature be in all of of calligra ? that said we are closed for features until 3.0 is released

On February 28th, 2015, 7:54 p.m. UTC, Friedrich W. H. Kossebau wrote:

Would agree this should be a feature calligra wide.

WRT featue freeze, if it is nice feature, small code change, and well reviewed, I would be for still letting that in. No rules without reasonable exceptions.

Not yet looked at the code in detail, though.

On February 28th, 2015, 7:58 p.m. UTC, Boudewijn Rempt wrote:

Maybe, maybe not. Calligra apps that use the sidebar instead of dockers probably don't need it. In any case, Krita no longer shares the komain and the mainwindow code with the rest of calligra, so if the rest of calligra wants this feature, it can be implemented -- but there's no need for Moritz to do that.

On February 28th, 2015, 8:23 p.m. UTC, Friedrich W. H. Kossebau wrote:

No need, but would be great :) (Besides, the sidebar is not integrating all the dockers, there are still quite some normal ones also in those apps. And even hiding the titlebar of the sidebar would be nice to have). So Moritz, do you think you could give it a try to also do this patch for the KoMainWindow-based code?

On February 28th, 2015, 8:28 p.m. UTC, Boudewijn Rempt wrote:

If that scratches an itch, why not, but let this be clear: there is absolutely no obligation whatsoever.

Thank you for your replies. I added the changes to the KoMainWindow and it seems to work very well. I only tested with karbon though because compiling takes quite a long time on my 7 year old but absolutely silent machine, so I updated the patch with certain reserves because it really should be tested with all the depending applications. Kind regards

- Moritz

On February 28th, 2015, 1:01 p.m. UTC, Moritz Molch wrote:

Review request for Calligra.

By Moritz Molch.

Updated Feb. 28, 2015, 1:01 p.m.

Repository: calligra

Description

Inspired by kdenlive, this small patch adds the option to show/hide the titlebars of all dockers to the settings menu.

Testing

Tested on Ubuntu 14.04

Diffs

krita/ui/KisMainWindow.cpp (e8c6009)
krita/ui/kis_config.h (b6852de)
krita/ui/kis_config.cc (a09c7b8)
libs/widgets/KoDockWidgetTitleBar.cpp (cf0c722)
krita/krita.action (b683185)
krita/krita.rc (0ec0931)
krita/ui/KisMainWindow.h (9cdcce5)

View Diff