'Re: Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi
From:       "Wojciech Kosowicz" <pcellix () gmail ! com>
Date:       2015-02-28 23:35:12
Message-ID: 20150228233512.12884.84482 () probe ! kde ! org
[Download RAW message or body]

--===============3083927282237957850==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/
-----------------------------------------------------------

(Updated Feb. 28, 2015, 11:35 p.m.)

Review request for Calligra, Adam Pigg and Jarosław Staniek.

Repository: calligra

Description
-------

When hash sign (#) appears in csv file at the beginning of the line or in the middle \
of unqouted field it is treated as the beginning of the comment and the following \
data is being ignored until the end of the row

Diffs (updated)
-----

  kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 
  kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd 
  kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 
  libs/widgets/KoCsvImportDialog.cpp 8d042d7 

Diff: https://git.reviewboard.kde.org/r/120940/diff/

Testing
-------

Able to activate/deactivate parsing comments. When activated able to choose specific \
sign

Thanks,

Wojciech Kosowicz

--===============3083927282237957850==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120940/">https://git.reviewboard.kde.org/r/120940/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Adam Pigg and Jarosław Staniek.</div>
<div>By Wojciech Kosowicz.</div>

<p style="color: grey;"><i>Updated Feb. 28, 2015, 11:35 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When hash sign (#) appears in csv file at the \
beginning of the line or in the middle of unqouted field it is treated as the \
beginning of the comment and the following data is being ignored until the end of the \
row</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Able to activate/deactivate parsing comments. When \
activated able to choose specific sign</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/plugins/importexport/csv/kexicsvimportdialog.h <span style="color: \
grey">(3dc3fe4)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: \
grey">(6572285)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvwidgets.h <span style="color: \
grey">(1e87dbd)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvwidgets.cpp <span style="color: \
grey">(3cf6ea4)</span></li>

 <li>libs/widgets/KoCsvImportDialog.cpp <span style="color: \
grey">(8d042d7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120940/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3083927282237957850==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 