[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110624: Epub generation improvement (new metadata)
From: "Elvis Stansvik" <elvstone () gmail ! com>
Date: 2013-05-30 20:06:27
Message-ID: 20130530200627.16892.39251 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110624/#review33472
-----------------------------------------------------------
filters/words/epub/EpubFile.cpp
<http://git.reviewboard.kde.org/r/110624/#comment24739>
could put a break; after this line.
- Elvis Stansvik
On May 30, 2013, 7:59 p.m., Jérémy BOURDIOL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110624/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 7:59 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> A little improvement of Epub export with new metadata like author and subjects.
>
>
> Diffs
> -----
>
> filters/words/epub/EpubFile.cpp 8e69d65
>
> Diff: http://git.reviewboard.kde.org/r/110624/diff/
>
>
> Testing
> -------
>
> The generated Epud is tested on Callibre to know if metadata are readable
> It's also checked with http://validator.idpf.org/
>
> Here is an error occuring when there is no cover image, not of my fate, that's it \
> in master (as i'm writting): (ERROR OEBPS/toc.ncx 14 11 element "navMap" \
> incomplete; missing required element "navPoint")
>
> Thanks,
>
> Jérémy BOURDIOL
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110624/">http://git.reviewboard.kde.org/r/110624/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110624/diff/2/?file=147132#file147132line259" \
style="color: black; font-weight: bold; text-decoration: \
underline;">filters/words/epub/EpubFile.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KoFilter::ConversionStatus EpubFile::writeOpf(KoStore *epubStore,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">258</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">atLeastOneInfo</span> <span class="o">=</span> <span \
class="nb">true</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could put a \
break; after this line.</pre> </div>
<br />
<p>- Elvis</p>
<br />
<p>On May 30th, 2013, 7:59 p.m. UTC, Jérémy BOURDIOL wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jérémy BOURDIOL.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 7:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A little improvement of Epub export with new metadata like author and \
subjects.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The generated Epud is tested on Callibre to know if metadata are \
readable It's also checked with http://validator.idpf.org/
Here is an error occuring when there is no cover image, not of my fate, that's it \
in master (as i'm writting): (ERROR OEBPS/toc.ncx 14 11 element \
"navMap" incomplete; missing required element "navPoint")</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/epub/EpubFile.cpp <span style="color: grey">(8e69d65)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110624/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic