--===============0120944754036704575== Content-Type: multipart/alternative; boundary="===============1082041224741520877==" --===============1082041224741520877== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110624/#review33472 ----------------------------------------------------------- filters/words/epub/EpubFile.cpp could put a break; after this line. - Elvis Stansvik On May 30, 2013, 7:59 p.m., Jérémy BOURDIOL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110624/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 7:59 p.m.) > > > Review request for Calligra. > > > Description > ------- > > A little improvement of Epub export with new metadata like author and subjects. > > > Diffs > ----- > > filters/words/epub/EpubFile.cpp 8e69d65 > > Diff: http://git.reviewboard.kde.org/r/110624/diff/ > > > Testing > ------- > > The generated Epud is tested on Callibre to know if metadata are readable > It's also checked with http://validator.idpf.org/ > > Here is an error occuring when there is no cover image, not of my fate, that's it in master (as i'm writting): > (ERROR OEBPS/toc.ncx 14 11 element "navMap" incomplete; missing required element "navPoint") > > > Thanks, > > Jérémy BOURDIOL > > --===============1082041224741520877== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110624/

filters/words/epub/EpubFile.cpp (Diff revision 2)
KoFilter::ConversionStatus EpubFile::writeOpf(KoStore *epubStore,
		258	atLeastOneInfo = true;

could put a break; after this line.

- Elvis

On May 30th, 2013, 7:59 p.m. UTC, Jérémy BOURDIOL wrote:

Review request for Calligra.

By Jérémy BOURDIOL.

Updated May 30, 2013, 7:59 p.m.

Description

A little improvement of Epub export with new metadata like author and subjects.

Testing

The generated Epud is tested on Callibre to know if metadata are readable
It's also checked with http://validator.idpf.org/

Here is an error occuring when there is no cover image, not of my fate, that's it in master (as i'm writting):
(ERROR	OEBPS/toc.ncx	14	11	element "navMap" incomplete; missing required element "navPoint")

Diffs

filters/words/epub/EpubFile.cpp (8e69d65)

View Diff

--===============1082041224741520877==-- --===============0120944754036704575== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel --===============0120944754036704575==--