'Re: Review Request 110624: Epub generation improvement (new metadata)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 110624: Epub generation improvement (new metadata)
From:       Jérémy BOURDIOL <jerembo () wanadoo ! fr>
Date:       2013-05-30 19:59:53
Message-ID: 20130530195953.15882.26629 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110624/
-----------------------------------------------------------

(Updated May 30, 2013, 7:59 p.m.)

Review request for Calligra.

Changes
-------

Improving robustness in <guide> creation

Description
-------

A little improvement of Epub export with new metadata like author and subjects.

Diffs (updated)
-----

  filters/words/epub/EpubFile.cpp 8e69d65 

Diff: http://git.reviewboard.kde.org/r/110624/diff/

Testing
-------

The generated Epud is tested on Callibre to know if metadata are readable
It's also checked with http://validator.idpf.org/

Here is an error occuring when there is no cover image, not of my fate, that's it in \
master (as i'm writting): (ERROR	OEBPS/toc.ncx	14	11	element "navMap" incomplete; \
missing required element "navPoint")

Thanks,

Jérémy BOURDIOL

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110624/">http://git.reviewboard.kde.org/r/110624/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Jérémy BOURDIOL.</div>

<p style="color: grey;"><i>Updated May 30, 2013, 7:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Improving robustness in &lt;guide&gt; creation</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A little improvement of Epub export with new metadata like author and \
subjects.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The generated Epud is tested on Callibre to know if metadata are \
readable It&#39;s also checked with http://validator.idpf.org/

Here is an error occuring when there is no cover image, not of my fate, that&#39;s it \
in master (as i&#39;m writting): (ERROR	OEBPS/toc.ncx	14	11	element \
&quot;navMap&quot; incomplete; missing required element &quot;navPoint&quot;)</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/words/epub/EpubFile.cpp <span style="color: grey">(8e69d65)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110624/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 