'Review Request:'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request:
From:       "Sujith Haridasan" <sujith.h () gmail ! com>
Date:       2012-02-04 10:42:19
Message-ID: 20120204104219.12961.53041 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103863/
-----------------------------------------------------------

Review request for Calligra and Shantanu Tushar Jha.

Description
-------

Hide the left button when user is in the first page of the spreadsheet. Sim=
ilarly hide the right button when user is in the last page of the spreadshe=
et.

Diffs
-----

  active/qml/SpreadsheetLeftToolbar.qml ce47af4 =

  active/qml/SpreadsheetRightToolbar.qml cc1ef43 =

  active/src/CASpreadsheetHandler.h 1f21a85 =

  active/src/CASpreadsheetHandler.cpp 8869a2b =

Diff: http://git.reviewboard.kde.org/r/103863/diff/diff

Testing
-------

Testing was done by opening a spreadsheet doc.
1) Initially when the page is loaded, the previous button is not visible an=
d when user navigates through next sheet(s) it appears.
2) When user reaches the last sheet, the next button disappears. After that=
 if user navigates to previous slide(s) it does appear.

Thanks,

Sujith Haridasan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103863/">http://git.reviewboard.kde.org/r/103863/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Shantanu Tushar Jha.</div>
<div>By Sujith Haridasan.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hide the left button when user is in the first page of the spreadsheet. \
Similarly hide the right button when user is in the last page of the \
spreadsheet.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing was done by opening a spreadsheet doc. 1) Initially when the \
page is loaded, the previous button is not visible and when user navigates through \
next sheet(s) it appears. 2) When user reaches the last sheet, the next button \
disappears. After that if user navigates to previous slide(s) it does appear.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>active/qml/SpreadsheetLeftToolbar.qml <span style="color: \
grey">(ce47af4)</span></li>

 <li>active/qml/SpreadsheetRightToolbar.qml <span style="color: \
grey">(cc1ef43)</span></li>

 <li>active/src/CASpreadsheetHandler.h <span style="color: \
grey">(1f21a85)</span></li>

 <li>active/src/CASpreadsheetHandler.cpp <span style="color: \
grey">(8869a2b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103863/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 