[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request:
From: "Shantanu Tushar Jha" <shaan7in () gmail ! com>
Date: 2012-02-05 17:05:57
Message-ID: 20120205170557.28928.55974 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103863/#review10357
-----------------------------------------------------------
Ship it!
Looks good, just fix the following issue (add the signal and emit it when s=
heetcount changes, which happens when document finishes loading) and commit=
&push it :)
active/src/CASpreadsheetHandler.h
<http://git.reviewboard.kde.org/r/103863/#comment8525>
oops you missed the NOTIFY here, QML will complain if you don't have on=
e and binding magic won't work.
- Shantanu Tushar Jha
On Feb. 4, 2012, 10:42 a.m., Sujith Haridasan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103863/
> -----------------------------------------------------------
> =
> (Updated Feb. 4, 2012, 10:42 a.m.)
> =
> =
> Review request for Calligra and Shantanu Tushar Jha.
> =
> =
> Description
> -------
> =
> Hide the left button when user is in the first page of the spreadsheet. S=
imilarly hide the right button when user is in the last page of the spreads=
heet.
> =
> =
> Diffs
> -----
> =
> active/qml/SpreadsheetLeftToolbar.qml ce47af4 =
> active/qml/SpreadsheetRightToolbar.qml cc1ef43 =
> active/src/CASpreadsheetHandler.h 1f21a85 =
> active/src/CASpreadsheetHandler.cpp 8869a2b =
> =
> Diff: http://git.reviewboard.kde.org/r/103863/diff/diff
> =
> =
> Testing
> -------
> =
> Testing was done by opening a spreadsheet doc.
> 1) Initially when the page is loaded, the previous button is not visible =
and when user navigates through next sheet(s) it appears.
> 2) When user reaches the last sheet, the next button disappears. After th=
at if user navigates to previous slide(s) it does appear.
> =
> =
> Thanks,
> =
> Sujith Haridasan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103863/">http://git.reviewboard.kde.org/r/103863/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, just fix the \
following issue (add the signal and emit it when sheetcount changes, which happens \
when document finishes loading) and commit&push it :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103863/diff/1/?file=48678#file48678line33" \
style="color: black; font-weight: bold; text-decoration: \
underline;">active/src/CASpreadsheetHandler.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="kt">int</span> <span \
class="n">sheetCount</span> <span class="n">READ</span> <span \
class="n">sheetCount</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oops you \
missed the NOTIFY here, QML will complain if you don't have one and binding magic \
won't work.</pre> </div>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On February 4th, 2012, 10:42 a.m., Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Shantanu Tushar Jha.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2012, 10:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hide the left button when user is in the first page of the spreadsheet. \
Similarly hide the right button when user is in the last page of the \
spreadsheet.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing was done by opening a spreadsheet doc. 1) Initially when the \
page is loaded, the previous button is not visible and when user navigates through \
next sheet(s) it appears. 2) When user reaches the last sheet, the next button \
disappears. After that if user navigates to previous slide(s) it does appear.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/qml/SpreadsheetLeftToolbar.qml <span style="color: \
grey">(ce47af4)</span></li>
<li>active/qml/SpreadsheetRightToolbar.qml <span style="color: \
grey">(cc1ef43)</span></li>
<li>active/src/CASpreadsheetHandler.h <span style="color: \
grey">(1f21a85)</span></li>
<li>active/src/CASpreadsheetHandler.cpp <span style="color: \
grey">(8869a2b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103863/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic