'Review Request:'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request:
From:       "Torio Mlshi" <mlshi () lavabit ! com>
Date:       2011-11-01 19:25:07
Message-ID: 20111101192507.11997.39693 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103021/
-----------------------------------------------------------

Review request for Calligra.

Description
-------

This patch fixes issues, when clone layer wasn't updating despite its origi=
nal was changed.

KisNode::setDirty now calls setDirty of parent to let its clones know about=
 update. In MoveStrokeStrategy updating is now implemented via setDirty, so=
 clone layers will know about update.

Diffs
-----

  krita/image/kis_node.cpp 52881e7 =

  krita/plugins/tools/defaulttools/strokes/move_stroke_strategy.cpp df8b6da =

Diff: http://git.reviewboard.kde.org/r/103021/diff/diff

Testing
-------

Normal moving (when no clones) seems to have the same performance. Of cours=
e, performance becomes low when many clones are involved.

Unit tests have same results for me.

Thanks,

Torio Mlshi

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103021/">http://git.reviewboard.kde.org/r/103021/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Torio Mlshi.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes issues, when clone layer wasn&#39;t updating despite \
its original was changed.

KisNode::setDirty now calls setDirty of parent to let its clones know about update. \
In MoveStrokeStrategy updating is now implemented via setDirty, so clone layers will \
know about update.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Normal moving (when no clones) seems to have the same performance. Of \
course, performance becomes low when many clones are involved.

Unit tests have same results for me.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/image/kis_node.cpp <span style="color: grey">(52881e7)</span></li>

 <li>krita/plugins/tools/defaulttools/strokes/move_stroke_strategy.cpp <span \
style="color: grey">(df8b6da)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103021/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 