[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-08-25 8:47:57
Message-ID: 20130825084757.3434.90554 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111824/#review38519
-----------------------------------------------------------
Does anyone here have an actual iDevice for testing this?
- Mark Kretschmann
On July 31, 2013, 6:22 p.m., Vedant Agarwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111824/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 6:22 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> I created a new runnable class that performs transcoding of a single track \
> (IpodCopySingleTrack). I updated the existing code in IpodCopyTracksJob, renamed it \
> to IpodCopyTracks (since it does not extend ThreadWeaver::Job anymore) and ported \
> some of it to IpodCopySingleTrack.
>
> This addresses bug 317093.
> https://bugs.kde.org/show_bug.cgi?id=317093
>
>
> Diffs
> -----
>
> src/core-impl/collections/ipodcollection/CMakeLists.txt cb4ef06
> src/core-impl/collections/ipodcollection/IpodCollection.h 02e55f8
> src/core-impl/collections/ipodcollection/IpodCollectionLocation.h cc27e19
> src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp f8105f9
> src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.h PRE-CREATION
> src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.cpp PRE-CREATION
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.h PRE-CREATION
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.cpp PRE-CREATION
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 0258bf2
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp a7fd97e
>
> Diff: http://git.reviewboard.kde.org/r/111824/diff/
>
>
> Testing
> -------
>
> Builds and installs but I could not test actual transcoding since I do not have an \
> iPod.
>
> Thanks,
>
> Vedant Agarwala
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111824/">http://git.reviewboard.kde.org/r/111824/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does anyone here have an \
actual iDevice for testing this?</pre> <br />
<p>- Mark</p>
<br />
<p>On July 31st, 2013, 6:22 p.m. UTC, Vedant Agarwala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>
<p style="color: grey;"><i>Updated July 31, 2013, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I created a new runnable class that performs transcoding of a single \
track (IpodCopySingleTrack). I updated the existing code in IpodCopyTracksJob, \
renamed it to IpodCopyTracks (since it does not extend ThreadWeaver::Job anymore) and \
ported some of it to IpodCopySingleTrack.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and installs but I could not test actual transcoding since I do \
not have an iPod.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=317093">317093</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/ipodcollection/CMakeLists.txt <span style="color: \
grey">(cb4ef06)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollection.h <span style="color: \
grey">(02e55f8)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionLocation.h <span \
style="color: grey">(cc27e19)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp <span \
style="color: grey">(f8105f9)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h <span \
style="color: grey">(0258bf2)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp <span \
style="color: grey">(a7fd97e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111824/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic