--===============3749417044848190298== Content-Type: multipart/alternative; boundary="===============8152329482549260361==" --===============8152329482549260361== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/#review38519 ----------------------------------------------------------- Does anyone here have an actual iDevice for testing this? - Mark Kretschmann On July 31, 2013, 6:22 p.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111824/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 6:22 p.m.) > > > Review request for Amarok. > > > Description > ------- > > I created a new runnable class that performs transcoding of a single track (IpodCopySingleTrack). I updated the existing code in IpodCopyTracksJob, renamed it to IpodCopyTracks (since it does not extend ThreadWeaver::Job anymore) and ported some of it to IpodCopySingleTrack. > > > This addresses bug 317093. > https://bugs.kde.org/show_bug.cgi?id=317093 > > > Diffs > ----- > > src/core-impl/collections/ipodcollection/CMakeLists.txt cb4ef06 > src/core-impl/collections/ipodcollection/IpodCollection.h 02e55f8 > src/core-impl/collections/ipodcollection/IpodCollectionLocation.h cc27e19 > src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp f8105f9 > src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.h PRE-CREATION > src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.cpp PRE-CREATION > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.h PRE-CREATION > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.cpp PRE-CREATION > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 0258bf2 > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp a7fd97e > > Diff: http://git.reviewboard.kde.org/r/111824/diff/ > > > Testing > ------- > > Builds and installs but I could not test actual transcoding since I do not have an iPod. > > > Thanks, > > Vedant Agarwala > > --===============8152329482549260361== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/ 

Does anyone here have an actual iDevice for testing this?

- Mark


On July 31st, 2013, 6:22 p.m. UTC, Vedant Agarwala wrote:

Review request for Amarok.
By Vedant Agarwala.

Updated July 31, 2013, 6:22 p.m.

Description 

I created a new runnable class that performs transcoding of a single track (IpodCopySingleTrack). I updated the existing code in IpodCopyTracksJob, renamed it to IpodCopyTracks (since it does not extend ThreadWeaver::Job anymore) and ported some of it to IpodCopySingleTrack.

Testing 

Builds and installs but I could not test actual transcoding since I do not have an iPod.
Bugs: 317093

Diffs

  • src/core-impl/collections/ipodcollection/CMakeLists.txt (cb4ef06)
  • src/core-impl/collections/ipodcollection/IpodCollection.h (02e55f8)
  • src/core-impl/collections/ipodcollection/IpodCollectionLocation.h (cc27e19)
  • src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp (f8105f9)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.h (PRE-CREATION)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.cpp (PRE-CREATION)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.h (PRE-CREATION)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.cpp (PRE-CREATION)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h (0258bf2)
  • src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp (a7fd97e)

View Diff
--===============8152329482549260361==-- --===============3749417044848190298== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============3749417044848190298==--