[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sortin
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-08-25 8:49:21
Message-ID: 20130825084921.3595.49048 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109369/#review38520
-----------------------------------------------------------
What's the current status of this patch?
- Mark Kretschmann
On March 12, 2013, 6:27 p.m., Anmol Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109369/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 6:27 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> 1. Made a levelSort() function to sort tracks according to multiple parameters ( \
> Should i just be sorting tracks belonging to the same album? ) 2. Modified \
> copyUrlToCollection() to use QList instead of QMap 3. FileView's files are being \
> copied in the order of selection, thanks to using QLists ( is that acceptable? )
> Updates:
> Implemented changes as suggested by strohel
> 1. Moved levelSort function to the prepareCopy callers (CollectionTreeView)
> 2. Restored CollectionLocation.cpp to the old version, with QLists instead of QMaps
>
> Still not complete though, working on it.
>
>
> Diffs
> -----
>
> src/browsers/CollectionTreeView.h 3b2ca80
> src/browsers/CollectionTreeView.cpp fd9fe66
> src/browsers/collectionbrowser/CollectionWidget.h c281f41
> src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp be13551
> src/core-impl/collections/db/sql/SqlCollectionLocation.h 0bcf244
> src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 93efe97
> src/core-impl/collections/ipodcollection/IpodCollectionLocation.h cc27e19
> src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp f8105f9
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 3c2d9f2
> src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c
> src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.h \
> e40529f src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp \
> f60aff6 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h \
> 821f1b0 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp \
> c1b76f5 src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp a8d9f52
> src/core-impl/collections/support/PlaylistCollectionLocation.h 10a365f
> src/core-impl/collections/support/PlaylistCollectionLocation.cpp c885046
> src/core-impl/collections/support/TrashCollectionLocation.h 239a977
> src/core-impl/collections/support/TrashCollectionLocation.cpp 61c2e49
> src/core-impl/collections/umscollection/UmsCollection.cpp 6bebd98
> src/core-impl/collections/umscollection/UmsCollectionLocation.h 45ba596
> src/core-impl/collections/umscollection/UmsCollectionLocation.cpp e0ba0ac
> src/core/collections/CollectionLocation.h d37ccfb
> src/core/collections/CollectionLocation.cpp aecc068
> src/services/ServiceCollectionLocation.cpp d1cb0d8
> src/services/mp3tunes/Mp3tunesServiceCollectionLocation.h 2b06cb4
> src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp aa61072
>
> Diff: http://git.reviewboard.kde.org/r/109369/diff/
>
>
> Testing
> -------
>
> Seems to be copying tracks in the correct order now
>
>
> Thanks,
>
> Anmol Ahuja
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109369/">http://git.reviewboard.kde.org/r/109369/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the current \
status of this patch?</pre> <br />
<p>- Mark</p>
<br />
<p>On March 12th, 2013, 6:27 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated March 12, 2013, 6:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Made a levelSort() function to sort tracks according to multiple \
parameters ( Should i just be sorting tracks belonging to the same album? ) 2. \
Modified copyUrlToCollection() to use QList instead of QMap 3. FileView's files \
are being copied in the order of selection, thanks to using QLists ( is that \
acceptable? )
Updates:
Implemented changes as suggested by strohel
1. Moved levelSort function to the prepareCopy callers (CollectionTreeView)
2. Restored CollectionLocation.cpp to the old version, with QLists instead of QMaps
Still not complete though, working on it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems to be copying tracks in the correct order now</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/CollectionTreeView.h <span style="color: \
grey">(3b2ca80)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: \
grey">(fd9fe66)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.h <span style="color: \
grey">(c281f41)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp <span \
style="color: grey">(be13551)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.h <span style="color: \
grey">(0bcf244)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: \
grey">(93efe97)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionLocation.h <span \
style="color: grey">(cc27e19)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp <span \
style="color: grey">(f8105f9)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h <span \
style="color: grey">(3c2d9f2)</span></li>
<li>src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp <span \
style="color: grey">(8a40c6c)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.h \
<span style="color: grey">(e40529f)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp \
<span style="color: grey">(f60aff6)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h \
<span style="color: grey">(821f1b0)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp \
<span style="color: grey">(c1b76f5)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp <span \
style="color: grey">(a8d9f52)</span></li>
<li>src/core-impl/collections/support/PlaylistCollectionLocation.h <span \
style="color: grey">(10a365f)</span></li>
<li>src/core-impl/collections/support/PlaylistCollectionLocation.cpp <span \
style="color: grey">(c885046)</span></li>
<li>src/core-impl/collections/support/TrashCollectionLocation.h <span style="color: \
grey">(239a977)</span></li>
<li>src/core-impl/collections/support/TrashCollectionLocation.cpp <span \
style="color: grey">(61c2e49)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: \
grey">(6bebd98)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollectionLocation.h <span \
style="color: grey">(45ba596)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollectionLocation.cpp <span \
style="color: grey">(e0ba0ac)</span></li>
<li>src/core/collections/CollectionLocation.h <span style="color: \
grey">(d37ccfb)</span></li>
<li>src/core/collections/CollectionLocation.cpp <span style="color: \
grey">(aecc068)</span></li>
<li>src/services/ServiceCollectionLocation.cpp <span style="color: \
grey">(d1cb0d8)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollectionLocation.h <span style="color: \
grey">(2b06cb4)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp <span style="color: \
grey">(aa61072)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109369/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic