'Re: Review Request 112169: Stop after current track to tray menu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 112169: Stop after current track to tray menu
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-08-25 8:37:35
Message-ID: 20130825083735.2342.97329 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112169/#review38514
-----------------------------------------------------------

I can't say that I am 100% happy with this addition. It does add some noise to a menu \
which is currently very clearly structured, simple, and easy to understand. In fact \
for Amarok 2.8 we managed to remove one item from it which didn't seem important to \
us ("Configure").

On the other hand I can see how this function could be useful to some. I am wondering \
though why the keyboard shortcut doesn't suffice.

- Mark Kretschmann

On Aug. 20, 2013, 2:50 a.m., Shitikanth Kashyap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112169/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 2:50 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Add 'Stop after current track' action to tray menu.
> 
> 
> Diffs
> -----
> 
> src/TrayIcon.cpp 5262595 
> 
> Diff: http://git.reviewboard.kde.org/r/112169/diff/
> 
> 
> Testing
> -------
> 
> Tested with current HEAD.
> 
> 
> Thanks,
> 
> Shitikanth Kashyap
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112169/">http://git.reviewboard.kde.org/r/112169/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can&#39;t say that I \
am 100% happy with this addition. It does add some noise to a menu which is currently \
very clearly structured, simple, and easy to understand. In fact for Amarok 2.8 we \
managed to remove one item from it which didn&#39;t seem important to us \
(&quot;Configure&quot;).

On the other hand I can see how this function could be useful to some. I am wondering \
though why the keyboard shortcut doesn&#39;t suffice. </pre>
 <br />

<p>- Mark</p>

<br />
<p>On August 20th, 2013, 2:50 a.m. UTC, Shitikanth Kashyap wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Shitikanth Kashyap.</div>

<p style="color: grey;"><i>Updated Aug. 20, 2013, 2:50 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add &#39;Stop after current track&#39; action to tray menu.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with current HEAD.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/TrayIcon.cpp <span style="color: grey">(5262595)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112169/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 