[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 112248: 313504: prefer QLatin1String
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-08-25 8:24:10
Message-ID: 20130825082410.2641.32316 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112248/#review38513
-----------------------------------------------------------
Sorry, I am against this one because I think it considerably deteriorates code \
readability for very little performance gain.
Frank, most of the checks on EBN are for micro-optimizations. They are low hanging \
fruit, and as such they generally make sense to follow, but there are corner cases \
like this one where the cost outweighs the benefits.
- Mark Kretschmann
On Aug. 24, 2013, 5:32 p.m., Frank Meerkoetter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112248/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 5:32 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> QLatin1String is more efficient.
>
> http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
> [...]
> 33: Check for strings used improperly or should be i18n. [strings]...OOPS! 78 \
> issues found! [...]
>
>
> This addresses bug 313504.
> https://bugs.kde.org/show_bug.cgi?id=313504
>
>
> Diffs
> -----
>
> shared/tag_helpers/TagHelper.cpp 7528a77
> src/MediaDeviceCache.cpp 73e8f34
> src/ScriptManager.cpp 4b4fc14
> src/amarokurls/NavigationUrlGenerator.cpp 0456976
> src/amarokurls/NavigationUrlRunner.cpp bde18e5
> src/context/applets/info/InfoApplet.cpp 760b241
> src/context/engines/similarartists/SimilarArtistsEngine.cpp 898beb4
> src/context/engines/tabs/TabsEngine.cpp 24a89df
> src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3
> src/core-impl/collections/daap/DaapCollection.cpp 20e7b4f
> src/core-impl/collections/db/sql/SqlMeta.cpp b399ed3
> src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp 7ecdcfa
> src/core-impl/collections/support/ArtistHelper.cpp 4c3f742
> src/core-impl/collections/umscollection/UmsCollection.cpp ad38461
> src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp 6467964
> src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 80ea8de
> src/core-impl/collections/upnpcollection/UpnpMeta.cpp 9b660de
> src/core-impl/meta/cue/CueFileSupport.cpp 77d27e6
> src/core-impl/meta/file/File.cpp f2abea4
> src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 28e3b00
> src/core/support/Amarok.cpp ca59725
> src/dialogs/CollectionSetup.cpp 0672421
> src/services/amazon/AmazonStore.cpp eb42566
> src/services/ampache/AmpacheAccountLogin.cpp 26aebed
> src/services/ampache/AmpacheServiceQueryMaker.cpp b94c3b0
> src/services/lastfm/ScrobblerAdapter.cpp 3c81546
> src/services/magnatune/MagnatuneSqlCollection.cpp 2f50e90
> src/services/mp3tunes/Mp3tunesWorkers.cpp a7ebd36
> src/statsyncing/collection/CollectionProvider.cpp a26cec6
> src/widgets/Osd.cpp 32c46e9
> supplementary_scripts/licenseChecker/log.cpp ba9b0fd
> supplementary_scripts/licenseChecker/main.cpp 4e6bba8
> tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp ab41db3
> tests/core-impl/support/TestTrackLoader.cpp ce369e2
> utilities/afttagger/AFTTagger.cpp 5a60c6b
> utilities/amzdownloader/AmzDownloader.cpp e6771de
> utilities/collectionscanner/CollectionScanner.cpp dd4ae37
>
> Diff: http://git.reviewboard.kde.org/r/112248/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
>
> Thanks,
>
> Frank Meerkoetter
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112248/">http://git.reviewboard.kde.org/r/112248/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I am against this \
one because I think it considerably deteriorates code readability for very little \
performance gain.
Frank, most of the checks on EBN are for micro-optimizations. They are low hanging \
fruit, and as such they generally make sense to follow, but there are corner cases \
like this one where the cost outweighs the benefits.</pre> <br />
<p>- Mark</p>
<br />
<p>On August 24th, 2013, 5:32 p.m. UTC, Frank Meerkoetter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 5:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QLatin1String is more efficient.
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
33: Check for strings used improperly or should be i18n. [strings]...OOPS! 78 issues \
found! [...]
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests pass. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=313504">313504</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(7528a77)</span></li>
<li>src/MediaDeviceCache.cpp <span style="color: grey">(73e8f34)</span></li>
<li>src/ScriptManager.cpp <span style="color: grey">(4b4fc14)</span></li>
<li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: \
grey">(0456976)</span></li>
<li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: \
grey">(bde18e5)</span></li>
<li>src/context/applets/info/InfoApplet.cpp <span style="color: \
grey">(760b241)</span></li>
<li>src/context/engines/similarartists/SimilarArtistsEngine.cpp <span style="color: \
grey">(898beb4)</span></li>
<li>src/context/engines/tabs/TabsEngine.cpp <span style="color: \
grey">(24a89df)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollection.cpp <span style="color: \
grey">(3dfa7c3)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: \
grey">(20e7b4f)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: \
grey">(b399ed3)</span></li>
<li>src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp <span \
style="color: grey">(7ecdcfa)</span></li>
<li>src/core-impl/collections/support/ArtistHelper.cpp <span style="color: \
grey">(4c3f742)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: \
grey">(ad38461)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span \
style="color: grey">(6467964)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span \
style="color: grey">(80ea8de)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: \
grey">(9b660de)</span></li>
<li>src/core-impl/meta/cue/CueFileSupport.cpp <span style="color: \
grey">(77d27e6)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(f2abea4)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: \
grey">(28e3b00)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(ca59725)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(0672421)</span></li>
<li>src/services/amazon/AmazonStore.cpp <span style="color: \
grey">(eb42566)</span></li>
<li>src/services/ampache/AmpacheAccountLogin.cpp <span style="color: \
grey">(26aebed)</span></li>
<li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: \
grey">(b94c3b0)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.cpp <span style="color: \
grey">(3c81546)</span></li>
<li>src/services/magnatune/MagnatuneSqlCollection.cpp <span style="color: \
grey">(2f50e90)</span></li>
<li>src/services/mp3tunes/Mp3tunesWorkers.cpp <span style="color: \
grey">(a7ebd36)</span></li>
<li>src/statsyncing/collection/CollectionProvider.cpp <span style="color: \
grey">(a26cec6)</span></li>
<li>src/widgets/Osd.cpp <span style="color: grey">(32c46e9)</span></li>
<li>supplementary_scripts/licenseChecker/log.cpp <span style="color: \
grey">(ba9b0fd)</span></li>
<li>supplementary_scripts/licenseChecker/main.cpp <span style="color: \
grey">(4e6bba8)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp <span \
style="color: grey">(ab41db3)</span></li>
<li>tests/core-impl/support/TestTrackLoader.cpp <span style="color: \
grey">(ce369e2)</span></li>
<li>utilities/afttagger/AFTTagger.cpp <span style="color: \
grey">(5a60c6b)</span></li>
<li>utilities/amzdownloader/AmzDownloader.cpp <span style="color: \
grey">(e6771de)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: \
grey">(dd4ae37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112248/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic