--===============7401123413003327324== Content-Type: multipart/alternative; boundary="===============8344771557829383575==" --===============8344771557829383575== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112169/#review38514 ----------------------------------------------------------- I can't say that I am 100% happy with this addition. It does add some noise to a menu which is currently very clearly structured, simple, and easy to understand. In fact for Amarok 2.8 we managed to remove one item from it which didn't seem important to us ("Configure"). On the other hand I can see how this function could be useful to some. I am wondering though why the keyboard shortcut doesn't suffice. - Mark Kretschmann On Aug. 20, 2013, 2:50 a.m., Shitikanth Kashyap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112169/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 2:50 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Add 'Stop after current track' action to tray menu. > > > Diffs > ----- > > src/TrayIcon.cpp 5262595 > > Diff: http://git.reviewboard.kde.org/r/112169/diff/ > > > Testing > ------- > > Tested with current HEAD. > > > Thanks, > > Shitikanth Kashyap > > --===============8344771557829383575== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112169/

I can't say that I am 100% happy with this addition. It does add some noise to a menu which is currently very clearly structured, simple, and easy to understand. In fact for Amarok 2.8 we managed to remove one item from it which didn't seem important to us ("Configure").

On the other hand I can see how this function could be useful to some. I am wondering though why the keyboard shortcut doesn't suffice.

- Mark

On August 20th, 2013, 2:50 a.m. UTC, Shitikanth Kashyap wrote:

Review request for Amarok.

By Shitikanth Kashyap.

Updated Aug. 20, 2013, 2:50 a.m.

Description

Add 'Stop after current track' action to tray menu.

Testing

Tested with current HEAD.

Diffs

src/TrayIcon.cpp (5262595)

View Diff

--===============8344771557829383575==-- --===============7401123413003327324== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============7401123413003327324==--