[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: Helper Methods for FileType Enum in new Class
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2010-11-05 20:44:55
Message-ID: 20101105204455.350.21964 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-05 20:18:22, Sergey Ivanov wrote:
> > src/widgets/MetaQueryWidget.cpp, line 594
> > <http://git.reviewboard.kde.org/r/100088/diff/7/?file=3259#file3259line594>
> >
> > And you will add "Other" to this Combobox.
> > I guess you should start loop from 1 again. :)
Nope ... that is intended ... at least as long as we don't have (nearly) every \
possible FileType as enum in FileType.h ... this way you can search for other formats \
then the rest in the list
- Stefan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/#review306
-----------------------------------------------------------
On 2010-11-05 19:48:36, Stefan Derkits wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100088/
> -----------------------------------------------------------
>
> (Updated 2010-11-05 19:48:36)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> -) Created new Class with some Helper Functions
> -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
> -) Meta::SqlTrack.type() now gets it's Information from the Database instead of the \
> FileExtension
>
> Diffs
> -----
>
> shared/FileType.h 55c80b9
> shared/FileType.cpp PRE-CREATION
> src/CMakeLists.txt b114bcd
> src/browsers/CollectionTreeItemModelBase.cpp 3f64a73
> src/core-impl/collections/db/sql/CMakeLists.txt 858f5c3
> src/core-impl/collections/db/sql/SqlMeta.h f1ee131
> src/core-impl/collections/db/sql/SqlMeta.cpp 006c805
> src/core-impl/collections/support/MemoryFilter.cpp e2509ac
> src/widgets/MetaQueryWidget.cpp 0249edf
> tests/synchronization/CMakeLists.txt e5df2df
> utilities/collectionscanner/CMakeLists.txt 22f3f1c
> utilities/collectionscanner/Track.cpp 9291662
>
> Diff: http://git.reviewboard.kde.org/r/100088/diff
>
>
> Testing
> -------
>
> Tested in the App, found no wrong Behaviour
>
>
> Thanks,
>
> Stefan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100088/">http://git.reviewboard.kde.org/r/100088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 5th, 2010, 8:18 p.m., <b>Sergey \
Ivanov</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100088/diff/7/?file=3259#file3259line594" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/MetaQueryWidget.cpp</a> <span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">MetaQueryWidget::populateComboBox( QString collectionId, QStringList results \
)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">594</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">combo</span><span class="o">-></span><span class="n">addItem</span><span \
class="p">(</span> <span class="s">"mp3"</span><span class="p">,</span> \
<span class="p">(</span><span class="kt">int</span><span class="p">)</span><span \
class="n">Amarok</span><span class="o">::</span><span class="n">Mp3</span> <span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">594</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span \
class="p">(</span><span class="kt">int</span> <span class="n">listpos</span><span \
class="o">=</span><span class="mi">0</span><span class="p">;</span><span \
class="n">listpos</span><span class="o"><</span><span \
class="n">filetypes</span><span class="p">.</span><span class="n">size</span><span \
class="p">();</span><span class="n">listpos</span><span class="o">++</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And you will add \
"Other" to this Combobox. I guess you should start loop from 1 again. \
:)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope ... \
that is intended ... at least as long as we don't have (nearly) every possible \
FileType as enum in FileType.h ... this way you can search for other formats then the \
rest in the list</pre> <br />
<p>- Stefan</p>
<br />
<p>On November 5th, 2010, 7:48 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-11-05 19:48:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-) Created new Class with some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of \
the FileExtension</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in the App, found no wrong Behaviour</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(55c80b9)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b114bcd)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: \
grey">(3f64a73)</span></li>
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: \
grey">(858f5c3)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.h <span style="color: \
grey">(f1ee131)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: \
grey">(006c805)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: \
grey">(e2509ac)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(0249edf)</span></li>
<li>tests/synchronization/CMakeLists.txt <span style="color: \
grey">(e5df2df)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: \
grey">(22f3f1c)</span></li>
<li>utilities/collectionscanner/Track.cpp <span style="color: \
grey">(9291662)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100088/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic