From amarok-devel Fri Nov 05 20:44:55 2010 From: "Stefan Derkits" Date: Fri, 05 Nov 2010 20:44:55 +0000 To: amarok-devel Subject: Re: Review Request: Helper Methods for FileType Enum in new Class Message-Id: <20101105204455.350.21964 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=128898994927527 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0721386255==" --===============0721386255== Content-Type: multipart/alternative; boundary="===============9121277932979807109==" --===============9121277932979807109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-05 20:18:22, Sergey Ivanov wrote: > > src/widgets/MetaQueryWidget.cpp, line 594 > > > > > > And you will add "Other" to this Combobox. > > I guess you should start loop from 1 again. :) Nope ... that is intended ... at least as long as we don't have (nearly) ev= ery possible FileType as enum in FileType.h ... this way you can search for= other formats then the rest in the list - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review306 ----------------------------------------------------------- On 2010-11-05 19:48:36, Stefan Derkits wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100088/ > ----------------------------------------------------------- > = > (Updated 2010-11-05 19:48:36) > = > = > Review request for Amarok. > = > = > Summary > ------- > = > -) Created new Class with some Helper Functions > -) Changed MetaQueryWidget to use the QStringList that contains all Filet= ypes > -) Meta::SqlTrack.type() now gets it's Information from the Database inst= ead of the FileExtension > = > = > Diffs > ----- > = > shared/FileType.h 55c80b9 = > shared/FileType.cpp PRE-CREATION = > src/CMakeLists.txt b114bcd = > src/browsers/CollectionTreeItemModelBase.cpp 3f64a73 = > src/core-impl/collections/db/sql/CMakeLists.txt 858f5c3 = > src/core-impl/collections/db/sql/SqlMeta.h f1ee131 = > src/core-impl/collections/db/sql/SqlMeta.cpp 006c805 = > src/core-impl/collections/support/MemoryFilter.cpp e2509ac = > src/widgets/MetaQueryWidget.cpp 0249edf = > tests/synchronization/CMakeLists.txt e5df2df = > utilities/collectionscanner/CMakeLists.txt 22f3f1c = > utilities/collectionscanner/Track.cpp 9291662 = > = > Diff: http://git.reviewboard.kde.org/r/100088/diff > = > = > Testing > ------- > = > Tested in the App, found no wrong Behaviour > = > = > Thanks, > = > Stefan > = > --===============9121277932979807109== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100088/

On November 5th, 2010, 8:18 p.m., Sergey Iv= anov wrote:

= = =
src/widgets/MetaQueryWidget.cpp (Diff revision 7) 
MetaQueryWidget::populateComboBox( QString collectionId, QStringLis=
t results )
594 
    combo->addItem( "mp3", (int)Amarok::Mp3 );
 594 
    for (int listpos=3D0=
;listpos<filetypes.siz=
e();listpos++)
 
And you w=
ill add "Other" to this Combobox.
I guess you should start loop from 1 again. :)
Nope ... that is intended ... at least as long as we don't have =
(nearly) every possible FileType as enum in FileType.h ... this way you can=
 search for other formats then the rest in the list

- Stefan


On November 5th, 2010, 7:48 p.m., Stefan Derkits wrote:

Review request for Amarok.
By Stefan Derkits.

Updated 2010-11-05 19:48:36

Descripti= on 

-) Created new Class with some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetyp=
es
-) Meta::SqlTrack.type() now gets it's Information from the Database in=
stead of the FileExtension

Testing <= /h1> 
Tested in the App, found no wrong Behaviour

Diffs=

  • shared/FileType.h (55c80b9)
  • shared/FileType.cpp (PRE-CREATION)<= /li>
  • src/CMakeLists.txt (b114bcd)
  • src/browsers/CollectionTreeItemModelBase.cpp (3f64a73)
  • src/core-impl/collections/db/sql/CMakeLists.txt (858f5c3)
  • src/core-impl/collections/db/sql/SqlMeta.h (f1ee131)
  • src/core-impl/collections/db/sql/SqlMeta.cpp (006c805)
  • src/core-impl/collections/support/MemoryFilter.cpp (e2509ac)
  • src/widgets/MetaQueryWidget.cpp (0249edf)<= /span>
  • tests/synchronization/CMakeLists.txt (e5df= 2df)
  • utilities/collectionscanner/CMakeLists.txt (22f3f1c)
  • utilities/collectionscanner/Track.cpp (929= 1662)

View Diff
--===============9121277932979807109==-- --===============0721386255== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============0721386255==--