This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/

On November 5th, 2010, 8:18 p.m., Sergey Ivanov wrote:

src/widgets/MetaQueryWidget.cpp (Diff revision 7)
MetaQueryWidget::populateComboBox( QString collectionId, QStringList results )
594
    combo->addItem( "mp3", (int)Amarok::Mp3 );
594
    for (int listpos=0;listpos<filetypes.size();listpos++)
And you will add "Other" to this Combobox.
I guess you should start loop from 1 again. :)
Nope ... that is intended ... at least as long as we don't have (nearly) every possible FileType as enum in FileType.h ... this way you can search for other formats then the rest in the list

- Stefan


On November 5th, 2010, 7:48 p.m., Stefan Derkits wrote:

Review request for Amarok.
By Stefan Derkits.

Updated 2010-11-05 19:48:36

Description

-) Created new Class with some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of the FileExtension

Testing

Tested in the App, found no wrong Behaviour

Diffs

  • shared/FileType.h (55c80b9)
  • shared/FileType.cpp (PRE-CREATION)
  • src/CMakeLists.txt (b114bcd)
  • src/browsers/CollectionTreeItemModelBase.cpp (3f64a73)
  • src/core-impl/collections/db/sql/CMakeLists.txt (858f5c3)
  • src/core-impl/collections/db/sql/SqlMeta.h (f1ee131)
  • src/core-impl/collections/db/sql/SqlMeta.cpp (006c805)
  • src/core-impl/collections/support/MemoryFilter.cpp (e2509ac)
  • src/widgets/MetaQueryWidget.cpp (0249edf)
  • tests/synchronization/CMakeLists.txt (e5df2df)
  • utilities/collectionscanner/CMakeLists.txt (22f3f1c)
  • utilities/collectionscanner/Track.cpp (9291662)

View Diff