[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: UI: wrong values in amarok's theme color scheme
From:       Martin <darklight.xdarklight () googlemail ! com>
Date:       2010-08-09 19:48:36
Message-ID: 201008092148.36700.darklight.xdarklight () googlemail ! com
[Download RAW message or body]

Hi,

as promised: here's the update-email with the patches attached.
I've also pushed the code to my clone at gitorious - see here: [0].

Here's a list of changes:
-small code cleanup for lyrics related code
-the lyrics in the LyricsApplet are now updated if the user changes them in 
TagDialog
-due to change #2: the user now gets a warning when some of his changes he 
made to the lyrics in the LyricsApplet might get lost (see a screenshot of it 
here: [1]) -> this fixes bug 207621 ([3])
-I also ported the other KMessageBox (which showed up when the user clicked 
the "refresh" button) to Plasma::Applet's showMessage()

Any comments regarding my patches are welcome :)

PS: I have commit-access to amarok's git repository.
If you want I will commit the changes myself (and resolve any conflicts if 
necessary).

Regards,
Martin

[0] http://gitorious.org/~xdarklight/amarok/xdarklights-clone/commits/improve-
lyrics-handling
[1] http://www.abload.de/img/amarokscreenprh2.png
[3] https://bugs.kde.org/show_bug.cgi?id=207621

["amarok-improve-lyrics-handling.tar.bz" (application/x-bzip-compressed-tar)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


[prev in list] [next in list] [prev in thread] [next in thread]