[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    UI: wrong values in amarok's theme color scheme
From:       Martin <darklight.xdarklight () googlemail ! com>
Date:       2010-08-08 21:40:16
Message-ID: 201008082340.16125.darklight.xdarklight () googlemail ! com
[Download RAW message or body]

Hi,

since I'm fixing bug 207621 ([0]) right now I had to try out something.
I need user input in the LyricsApplet, so I thought calling KMessageBox() is 
cool - unfortunately it isn't in a Plasma::Applet.

I wanted the applet to be blocked when my KMessageBox is waiting for user 
input.
Unfortunately this isn't possible with KMessageBox so I changed my code to 
showMessage(), which is part of Plasma::Applet.
It provides a nice way to show a message in the applet itself.
(as a small side-note: notmart pushed a fix to block mouse input - see [2])

After porting my code I found that the applet was using wrong colors for the 
message. See here: [1].
Since I wanted this to be fixed I asked in #plasma to find out the reason:
> <notmart> is a problem of the amarok theme colors file

OK... so I went ahead and fixed it in my local branch (sorry, I won't be able 
to push my code today - but I'll do it tomorrow, I promise ;)).
I simply changed the default foreground color to white (since the default 
background color is black)
I'm not sure if this is OK or not, so I need feedback from the UI magicians :)

In my opinion the applet should use values from KDE's color scheme - but I'm 
not sure how to achieve this.

Regards,
Martin

[0] https://bugs.kde.org/show_bug.cgi?id=207621
[1] http://www.abload.de/img/amaroktestg4i1.png
[2] 
http://websvn.kde.org/branches/KDE/4.5/kdelibs/plasma/applet.cpp?r1=1143427&r2=1160688
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]