--Boundary-00=_UuFYMmEhGve+tjZ Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi, as promised: here's the update-email with the patches attached. I've also pushed the code to my clone at gitorious - see here: [0]. Here's a list of changes: -small code cleanup for lyrics related code -the lyrics in the LyricsApplet are now updated if the user changes them in TagDialog -due to change #2: the user now gets a warning when some of his changes he made to the lyrics in the LyricsApplet might get lost (see a screenshot of it here: [1]) -> this fixes bug 207621 ([3]) -I also ported the other KMessageBox (which showed up when the user clicked the "refresh" button) to Plasma::Applet's showMessage() Any comments regarding my patches are welcome :) PS: I have commit-access to amarok's git repository. If you want I will commit the changes myself (and resolve any conflicts if necessary). Regards, Martin [0] http://gitorious.org/~xdarklight/amarok/xdarklights-clone/commits/improve- lyrics-handling [1] http://www.abload.de/img/amarokscreenprh2.png [3] https://bugs.kde.org/show_bug.cgi?id=207621 --Boundary-00=_UuFYMmEhGve+tjZ Content-Type: application/x-bzip-compressed-tar; name="amarok-improve-lyrics-handling.tar.bz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="amarok-improve-lyrics-handling.tar.bz" H4sIADtYYEwAA+09aXPbRrL7Wb9ioq1NKJOEcIOgj8Txkbh8KZay2a2tLdcAGIhYgwQXAC3rOf4l 7++8H/a6ZwY3SJGSJTu7QmKRxMz0HN3T13QDqqpq41+XAc3ZOJ+x8YvzNPKzh8tlzPJxFI6TBRv7 M7o4ZRkvj3n5OEyVJc392Z+2uVRVtU2T4Kdji09N/savqq3ZRNNMQ1Utw1Z1ouq6ZRh/IupW0K94 rbKcpjCUq8IRkyHl5x/kepomczJh1NaC0LKoH5hM1/yJzVTmGoHv0pBpahhOmG8yg7xMFuSYLYnm EFWd8v+JDijcQzBT8pKmebQgP8arOVtk8PU0JvcCmr6Lo9NZrnwov/5wmiSnMZvTKFb8ZP5g7zHQ 35QcrxYjMiEPV6cAVVOJ5k5NZ2q6ZKhCL3vHK+9fzM+n5B9HD08e/UxU7VBT/0kE9RKgTlKnXhKF BKiXSOrl5YJ6SYiTPqGnjyMaJ6fKHnmVYPfPoH58TnKW5SyA+lFGzqJ8Ro7/HT9K4hi6jmD+Y+Kt AHhOslmyigNC4ywhZ0n6TlTGbl6xZTJfvasa7e2Nx+M9kqX+oZ8scvYhP2SL02jBskMxpEMx8if8 puIvl0Rev8M/QyPD7rUDvBkhdXhaAQ9AKIoCIIpxZocLMfTq1qGczElK/Xd8ZAiC6GTYbZz9O641 hGV7yXJanw2pNcbBBxwB2WGFi0bl9sUbGzD4PWKRMIoBqwK7wYiYDokWGUv5SAbDgxH0EjCgA/57 fLC3F0RhSMbjU0AdPdwFFd4utfeiRcA+EHtihprqK4rlThyLUqJxJoh0sFvve4CnHUfwww9k7Loj DZYZPkyNwI33SRSQes3pdM6yjJ6yAQG4WU4eCejHOWymb0mGH+Rgr79hTmHL0Udi7QcE0Tydcgo5 ylOS4xds+3GPo03A95IkJjOayVbkvqg3frCgczY4IN/cJ/O3eZTHjPz+O9kbrycDUrREdpPlg4Mm DHH37t7wihBgGBfAAEYhVqZYCQnVp/6MBaJocHBwd4+IhYjCQX0FDvZKUCvOwwZY9RPUHvLFaq56 tze5sL8c5ymw2m/Jgp2JCgB5+FGM/fGTH3/96e2PL14/er43FLc47JTlf6UxICEE/sXuFmUSFpnl 81jCwgXxV2nKFrL7u82qy5hGi7KuvIszkSAPD8mcvmMkW6WMnLHv4O8iyQEB59g6Twj1faBEQhdk PwHOmoQkxfntl835jhK/gKcP2uN5AbgCKbJaAB7Jg/vAIA5E5Y8V+hBKzuaE5gIaVKKpkBl8/Ej5 UjpUjZoz6+n1HwDmn3I5PtXmC9iHDQBjrcmcGX1fyKKgNpcKZ0B5tVX/9ttmUX0svdPLooXPALf5 bFRNCxY14L9+Pnn5YlQMhUoUsH+vaNwAAtjA2tBzUbeawXeE859FTuagMzXmo1RASrrK0xVrLw0U rtKFrAOFWNDHYIrdUHKQFoORiOC/oauTGbQRTBGZWIoiKMU9Xa+HFHkpCTDbgfvOJPdnYWDqAQPu r1HL0/zLcf/Zjrx/xjm/rY4cMoS/oFXD72UKuo0PCs1ULOUe3Ineo7olfvPlr9gPZ7slKd+5U2D2 DjkB/pNtIOqSCGptfljSlM5rlHzSoK7eJpJIkH5avYVJyn9KtEo5Ux/DiAD9s/QsyphgbFUPhzXm txMrRUZWbrI8SUHpQMWQiY49xhYkiDLqxcDRB/ANIC34gkv2znucv01ht3HF8i6/3UeLKRtH82W8 qz7mXam5pFggT00LQ0VhqutMLKePYi/ZQZ2ILwkC6drQnZFNhvgxKTSaPVKvOp1mLH9Uk72kg9f3 NF6xmmoyf4u9A04VaHqUJktQIM8H5Jdf03hA9md5vpweHtI5TZN3yjvY0El6elioP4eaoh5yGvyz INB9Alqn7KEUf8Boo/D8tQeq6XuWZqWIF+PfkgrWK9abFnZtK4nzYKLalmsrSmBS0/bsbXG+Hu5F qF7fkuusqoUYxg+OYSjvx2sLreTbuBCM5OIL5Hg5hPEDGNExbGrUg0FgsMynS4YaRrqkYMwdICK3 agmbOwXCEYy0bPXpQipA7tClgn67yFtfVlodoW8xA+SO6WsOVbsY7W9d4a2/HLEzMSeIHfxwETtl jbUGwcPYW81RXlP8UmAH2OgzwdaLZqjy1fm6qA6KcsXWUxYnVKgyfgIrWOnTovL9mn52IlV7LACN sEYUCOMRNm+qpyevH7+etmSN7HlaWPnA7+HbGaHkjKYLJDpUrWj2jjdaAV4rdTUkcOuMLkBcgkIF ZS2l6vs6BwDM7GmKo+iKtrd38/4fVVX18UtYE+7dww3L5rCGlNM4CNwxbD2x6Z4mqVjZPMG6n83/ p1qWpbb9f46t3fr/buLi/j+TuQ71PF1lvktVxzNtg6mmY7tWaMMOnfgODQwN9t/N+/8sY2pY6/x/ Ovf/IfXyHdakXq4udqgXGII0csT9l3QBHDztcdA1ylt+Ke5FM5peuU2taw442Rqm2WyY+Wm0zIV6 f/iQaxwCxjEvqDxvwIPHYz5ao+0D0/W2D8za1gfWna23ubzQGwNq6JqnKC4NPUPr1RvXQehaN906 KHk0rvjBXwfkDjLOP4OtG68CRvZby7yPvpOqdI0SslqCypcfVu7Zevtm67LyY+atTlsVnrRMTtE/ jlifGCMgD31ijjQLhWXNnyM7A6UG5InQagYHhbrAP6QFJD0zQomoWckVgA5xt9Vdrp2CLjtqFxQK k7i/yVvU69u7TzqLN50C6eV04XN1iFeDYXE9+jn/W4xFKFXDwgcyKN2FpQ9BetE6Sl9cWWRYjcHy VI0CRBDs7nv3Sh8UYBBFN7o6wgilteyqsCNPo/dgvP365gUZ/EU7IGMSnS4SbKnsHyg0Pa2PmXsr ttw9bY9Bq7TQvo3AcG1fUUzqubqvb7tz+rwC7Rpcm9a4Mq2NNBMp0I9plpGHLx++ef387ZO/Hb1+ c9KkJzIly5UXR768LbltpT1xEhQ4eJKmSdrRwhnebWjMtSavkvxpslr0mNpJHmIBb1jzRlW+B7zu gNzJsxraWj4BgdnyBKZErdIA0oQovRMlktE5gdQg1VF+X+ltEm/0ZvCqh9Uvvgrbb1ZywW4tHRJN Rw5enM3U+UoNF13q3UbkeNvWlFRtMYe6JgObUjUtz3G7VL0NrIrCt6nNZcQEvV4amigoIyom3dOG s+l1jF7UxzrjLytINgg5bo7ZI9CQhhOLS0XSneZ0WlizLWrKgI3Lg5293nafT66Qj8KhWJcr42uU KuO2TClPkbaUKR0JG4fYcc+KVEtQgRBmnVyML23ZbXeBrWKMnxWK85iOM65Fj6WVOxb+gPHZLPJn 4ygbI3NZwM/PZ/9ppqN24j9s0761/27i4vaf41uOazn+ZEJtXzcd1wkdywyoahgu9SzTc5wJ1Sbq Tdt/ujY1jKmlr7P/DG7/ldQLCp6g3tJHI6iXcOpFrz2nXvgJukHhtiFzGtSCRJK6E2jwPqKduJKD 8lBN1jpjaXkAAfYXL/KAOZymqNYoPaYl5YBahzgCemnnTdy+oI+hsP12gIemJ7cbObw9oreNRmfS CZxQt7UaL5qIt0ttqUGEGjU1TVUUFvqGHljr9eKL4HX15ItacNvNQE0C/rY1iQukdNHHWRScYh8n GEzhY1WgxN/4zVaLwtcq5G5Nvrc0D37icMhd5U0ARxQGnrOfgSC74wHldM5qJqkuFAZdt0aA4GZI iFiC6RS9sSKcqkdPp3NWyPsjMCbmIMBh29Li0PZxEeUwfzujWXlsXlixlWzGTpQs+h8Mt7h/n6gg uoXFe7eyCbt1GkfMvDIp/Mk102//NCnO8TmMKdnH2/i1tC7QAZ1V+x/4VBwTFkTIr0oPbekbxiiw BWMB5w0ebHQa40mfx8DyYKjV82ZN57PSCFaIsicSeG0SyIl+XWT0PQuE1zz7TfCspmu6FtvWOPWU PTS73eUovLcLEX0TU4/FSoFLfg9pGaBH2mQxKPTR/dLSk5VeYDvQlWBm3PAQp3YTcwScx3ANoac2 6S1bncLMkdE8miUZW5REB4oVKJPR4l2lqTZbpixMWTYrYmxKTbMbKZDvujTjilS/Kdv//nv1owob KjDK67aQgS06ZxJVu9Iua5GzjM4JGWhXZRgFX0kXHWBDUzX7VrKzHnh9qgceFTBrSnGD8TRVbXFg 9RRblGdunekXUVOjWpmMozqoxV/t1s26Nas6a9eouqydq+CSmRb3gZjWBIPhOmv2jp0fwaJlT94D rAH55Tk751/JHUaqFeTxWIVOP2xCmCcgGqPCmngk4mMGVfSV9OQhD3gDKgjfRt/DT8FlwKBJfs7n MYx92rh5hLE7WHlwUI+Sae8B5Fn1DcCn7NojHRQmS3Ulm2+28WPYZ1WjPrDIlK55X5XNa/untX0k Aj5W1Co3We8yKcBk58v8nG+tssXHZhRh010VV4FdV8BOs4NyF1xkZ0reCzpBTRGVxNSJQytG3KQ2 HHk/+ZXcXfZShqMVQStyMEmKzreqalNwf9OEXq1wA7zAXNWudQSP6wAEQZcZex2GnQVr9ih4XVnh U/WVu3rXonX9qpfRiGRzz1JJqXXdXMFVTUZiV99lHSS1mVJnLC3sVXFFfIJzDCgHfefnaJEXx+i/ wGZ8ST9E89X8GIqqoAIhWi1dR+5mGf2itbGLe/c5y6ViUohdLnvq6koRY1hXYu5XNUr5X2wOAPmG 0eD1Ij6HvVqDJGvWwlwL2pTUcZK8jBZYwGcG2oKJMWxWN3q5HD2oGcdCfagOUOZvs+JWTRHhHHwN iDU6WMnBYYjHVJ4vtjao0oyD3Xl39oKua3ctnlvUKXS9JsV1QnilDfxSRHnXe31UD08tguiyVhyf UF4bXX6zNbOva7o4zWbkRD6jeX/faKnHrGKJZ1BUaOYXBQLW3O/NqVeK628c+nmyEjZ7D+QkJPe8 B3/RyJj8Rb936D1Ys0bkcSLgUOw+IUhEeCMtPAnf7482B48jtdZXt1J0dm64BDUjP3/VVLyap2Mb kNB/kILrUxLlAAvZB8p9K945+lm4SnewxZqfbFrcJtr7EDP/ype63FQPa6FAMB/KxxokSivKaJVx XgEaxG/RIkAGRWY4ZbAyl2niUS8+F+Hx6EQCRgbTPm/DeMNC6uccXxE3SwtzvM7YJCIA/mAGMmXa yo3KAInNZgf1jf9cNv8x+TCdStT+nWWvkoFgAfUJjFq4HzXtxKZ/DHOncH6c65Jzlu+j5x5t/EaX 0FdPmHvN0N+Al7sbG4hBtVWkmhFcEWvfIWCr322kPDYrFYq60OVaBylV/PaBj/RLzRN//3IeuPY5 9Ma60vvm6IbpqYai+KYGYti8nPet74x6c315hmfzM7yJ9LyFMKSQvPj7m2ePjt8+PDp68eTk7c9Q AHdBAHUL2rEfTcfZsM9bVwyg15VXubfWVDh+f1qcxznoMBw6lgiO7ImxD1jO0jnAesgPuJ6hysWT rUp1SJwTw94t9Lb2/Zq+I+mqLLrIl9SvpdSUEukpKOtVjh85ih5/5p2G60fobpMJdzOCBifiDpor 8QtC+TFNzpBLFtedQoG8u7lSqdvVXXnom0O+cr5pGXr1KbmhO1oUv/1rNJ2KQR0LF1+Gd1fR2+Jn 02FTMyfuNm5XpuXdWgJCTZ9G/ZTDKqIy3soYDUHWheU4avLvg891uqiqqjk+5ocy8TkecadFLCi3 GjEFvJb2jdajTAf/fPGfjmXpnfM/7Tb/+0Yufv7neZ7jsMALDUOHtXcC3dZZYJnqxDVtKDOorhlm YH+J8z9rqjvrzv9Mfv5XUC+R1CtMgwtS8C57LIeHkT3nccWpnNYJyeyerplf8nRNHqopCjXswA17 cz6u83QNNvbIMMC2x09ng22/jpMXGtta05n0sPqLTGd5OrXOdJaeyy1M53GpQV/BdC7dUDdnOpdd fiWm88bs764aXtlzOzZs23O8edPbeG2m84VrfjOm8xdb6nJTrTWdiwpXMZ2bMK7NdK42/ldkOrcZ liSmIo87ZTSGNdvg95PD+OZ+G5nNJxz0HNZsa6pvalCa6kWdC1ybfVNe597sTPUqLs4L2MR1uTk3 8Y6vzNV5eQfcVs5OvJoOzwtQ8pmcnpsw8HU4Pq9x4RubbrP7U1a6sgu0Aed63aB4fW38HK+PTcTt 7BJd06j0XTQUn4vcomXd3d2ivOmnzobd2hF7uV7L5p+KmfY7ZItq60tlZMhGr+0fIAIc82/HT6MP 3MsTwI5axTnm/TIRvTr2kzhJM54JvOT7ZAe/T62PTf4fXbWMlv9HM1Tn1v9zExf3/zCqWjbznMAx Q5Op8OEFmm+E2sRwbM/z9dCyKZ04X8D/Y1pTy17n/7G4/weol3MISb2kol4iqJeLeUm9NbcPClmW ld4LkQkzfpn471bLQ9mSR06bBN08fc6dnR85t02f3rY1pUuHqp5rTiaKovq2xtSeRMJtYFXunG1q 8ygN/qAh/hd+Pi1X/dkCxHL0nt3XDHsk/+3Vyl9Ei3f3Ndscaa4+0vVJvewVO6W8rTqC/5olKxAB 8X1t4ozkv71xrThJ51Aqmg0793XLGsl/daBHSRbJ7lyr2d9fIyhiwX0XujKdka46MuzGNvnzlcz1 07b0kfzXmTaOrzWGcsqa6qybNAwPR3gjE55MRtBOs1SUkF+/ALu9rnShbB4fJWnOFYCa4smycbRo Pg44T8ZCVx7Djc+X/+VYWuf5H+Zt/tfNXOL5H74bTnxGHdXVtdDxQqbbE0P1Tdf3bMMJLZ+ySRC6 Ny7/dXz+B2iHa+S/zeU/Ui9XABrUi5lYDVuvYyB+J/LBSgvxskdCrtOTqVUdCe2aqKVZZCj0jW6q lt1WOAz7Sx4myTMkRfFdNtEc7cZTtVyequW2U7XuPX+ULMJIPp/qQaPkpzjxaFyc4jfLjnO6ABoN HkcplIxrJRVlNVucUE+EQjxo2IL3BKUdYpBHUS5yOAxQXDAdRu+Nzv/8+TCXyEwpjfoiM0V66nsz U8pOmkHg9ayYzn1p6r+RoGq2fhClsMHjc0L5ExblEOF3kCy+y+vB641HjnI4BYpWeZ4seF4HJrEV W17c5r6UeoBk26VSVG8Ay6TxwL0+xa375JenMT3N7vU2edDX8++te6+SxsMymukJuAkG3H3kD8j+ D9EiTPZHZF/6BKXrvnANFlhpuDXRKYbI/Z48jOMywxVbz+m5WEue+3qG+W8eLGyS5cp+M1S+Qnef Gwz949FixR5hOk88IOqID7v0er1pDKvfvVXAKD1CtUzBK6csXSWXqHGkIJ7pKfEHgmPeQ2zk+NlP rx6+QHygk3YTWdadjPJ5oQOOsZEEMujtoWAHDZi4qtDsxeuTweatsKZt15crneZyBK3DI/k8PEmA QDayz8bJSl2ukufIBQdFuusYKRlMFGRy/IGZgmJ6dljb01aldfHk3KGpmyPT7Ulx4pQu7j1NeD5W DUArg0vMSmZcbL9unly+TU9OgpV8XD4OVrxzQDz1sI8gSBadLmhM8F0C5TOyT2V2qcg5rT9gkC7O xaNuCRVvJUh8oOOCK1ZPoR1cjp6aoc2NAzXu4F9Kit8HhO3XDw7lusAm72G8G+N536499eut1XsO efmo3jbcriv57UWRvZhWvOCI8WkGymy5WJhAjE/b7h7BQeU52N/KRaHBwz7K3Xmv//fQ7CWUnk52 +Q2Qf68OVKPKG5Z1n+rE1uapwO9zJrTqVcqZ9zPQ09OQ+sjh6+o2ubOk/Li6esqyLP8pTVZLRF8F BBQL8btI/bLVCeZ8DW1LHxnmtrlfu8aQfdwQRlagoRERtkNyV5OfXNyAXBzS1peBe2E2WA9f6418 K3WcHSJFumFu20eK1B+N0NN6M4evIk2+CpV9XUAKqapsGzTYWdGrBKS0lvcSoEj9urnYlka3X0ls y0VxbpePkNs6tmUTiPaG6fD9y4Fpj6WsWdnNxXVtcTaNXr7uKMnrI4JxIyJjc6ykrHTleMkGnOuN mcTrK4qzWfeQgZ3jGdc06lg3mwjjprZ2c9S7xP1w+JeL/cHrU0MZvoyX5WL7/bp8LZf0HEhLpbbm myOQKuYqH2bXfu9Af7TdJg+M3Dvc+9LeR/1+GIks7ka5sVRUmYGqKEFou4He8zKL60tFxYelWWSI H2b7oeP3VtHbZmqgMkP3/1AwXNya2RLsIknHPKVQPH25J4XyblH2y08pXc4A6FGafDhvF9YyIjnt tDvZG0t+Jeo/TaH8+P3p3frN6jACbsPOa1cddquRYgANbl4+KFq+MrBg6cUziGwT3XO2Id7iIhNA SRYneVZPiG08iqiR6lp7dEn9ftexV8+CvbQ/pA7kiu5AvmLtN26JsV/GgBYmsYsLOXRNzKu9xoTa IlFih4TabWtznrUFp+7N3SqEWI95u6ZmQyC13lbYuLpOR7JD9u9/RHAMxmSM37A5Zv1myRxjQEFn GfPXf+IzVbNLxHv29LEp/lNz9Fb+r2Yb+m38x41cPP4jsPXQ1AzdNVVmUM2npgmylvkG85mq8ndA a4Zr3fj7XzD+w5pqa9//7PD4D0G9BKm31Lhr9HvJqA5ikP6MXrUTg/ElQzBk5IWiuIy5urrhTZPX E4JhGvjEiyF+2N2juKuerpWWwUUueF5xCxc8r7cmTa0jDDbXWnMCNW64/i4ypHpE0S4nUFIvv4Ik Al41GT8CwAtk+ufxLs912KGPjfH/wG1a/N/QdfWW/9/Exfm/bzv+xHY83Q4MwzdcaumBpU+or6mh bXu26toTynz9y/B/PA7q5/8Tzv8F9RJOvcPhZdm9SdY8waHD77/o8xskm1cUNTB1ang3z++5HTLE z8k1MPzPz/LHguXfIFcuA5mK/i4dF8AB9PqHxOONHYELy+rDxeUDBG4GC31n32X5zZ19F9j6al7J eaMXyCp3LN5J9PkFf9XHjvJfc9Rb++9GLi7/KTOtcOL4BjUtCpydTgLbcV3QAcxJ4HnUD303VA12 4/LfmOruhvw/l8t/Tr0guv+zBb+U94qi674TTi75YMYrCH7dRjckfvQYen0xl31xRFfWD/peKFZK q88bulZA3RS6JszDzxG6xtfYNPkam/q1GNNr8gYuqyT8x6Liv0v+a+pY0BS+7P1adICL5L9ut/2/ umXe2v83cnH5b3kGCwA3DmO+67vahKqm49m+abiOwxxbnViTwPev/fmPAH5E3Eb+v2ZNMWGqV/5r qrD/C+otjX9x50VyWuXv46vPOhLebEv4jS8+q6B61ffiscl0YtkMzHIWTELLaeXgV7WF7K1+8zx6 /hYHYcGJZPtqAmiT/PXJm+Nnr18RXTEUffwjyynRkNs9ffLw5Nc3T46n4oTrDqlFQsnX0DWObSnn rWfyJQxB+Rq88/Yb7IooghMqTyQlc71DjpIAjNgclpAuOCyP4Zrm0D4gQBv4/M0oQN68CAimlS/F K/HCJIa7mUIGP74BrLqW5h4UMOWUNcUk+LxlD4xkfKVfkgLUKaEBHi/Kl6fyOLKIl/E3uOBThyuj 8QQm8I4HKL2k+f/977/ICxrlcRl7xllbMYKJ69oHUq/huSTSm7FurfE6QgB40vkmgrVKA/IiAQLH md5LY/n1h1mSl1StCEMaxOPTZ3+r4elp9IHh26jxrWTjOMkyEKr4kkLEQmlni3dX4xF5mbo1kwlb 8iWF0qAtsNV8MYmcKGxqXSuXGp+U4ac0myGu2Aegav7C5AUDAiDPHz8h7wFJSPxKNdm+PY1zfsri 6EOxND+xc5bKLk3L0ox6lzDXZUzP44i/YQQELWgDSRJ7NC3FPM4IJL0gSRFGsc9fx5Ms4vM/xHN0 bq/b6/a6vW6v2+v2ur3+KNf/Azg0OhcAoAAA --Boundary-00=_UuFYMmEhGve+tjZ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --Boundary-00=_UuFYMmEhGve+tjZ--