[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Fix for bug #207621 and a possible conflict with the string freeze
From:       Martin <darklight.xdarklight () googlemail ! com>
Date:       2010-08-08 21:52:32
Message-ID: 201008082352.33047.darklight.xdarklight () googlemail ! com
[Download RAW message or body]

Hi,

I know string freeze is in less than 48 hours, so I have a small problem.
I'm working on a fix for bug 207621 (see [0])

To fix this I have to add two new strings:
#1: While you were editing the lyrics of <b>%1 - %2</b> the track has changed. 
Do you want to save your changes?
#2: The lyrics of <b>%1 - %2</b> changed while you were editing them. Do you 
want to save your changes?

I tend to make sentences more complicated than they need to be :)
I will put my code up for review tomorrow evening - unfortunately that would 
mean there's no time left for any "fixes" on my side (as one of the developers 
would have to review my code instantly).

Thus it would be nice if someone could take a look at these strings.
Once they're "finalized" someone would have to add them to the code somewhere 
(even if they're not really used at that point).
Then my code could be reviewed and pushed (even after the string freeze), 
without breaking the string freeze :).

Here's a short explanation what those two strings are describing:
There are two use-cases:

#1: while the user is editing the lyrics of track A in the LyricsApplet the 
song changes (either due to a shortcut or since the song has ended and the 
next one from the playlist starts playing). The user needs to be informed that 
his changes might get lost. Now I'm asking the user if he wants to save his 
changes or not.

#2: The user is editing the lyrics of track A in the LyricsApplet. He starts 
making changes. Then he decides to open TagDialog (right-click -> "Edit Track 
Details") and change the lyrics there too (another possibility would be: his 
lyrics script is searching in the background but it's taking quite long until 
it gets a result. Then the lyrics would also get changed in the background).
Now I'm asking the user which lyrics he wants to use: the lyrics from the 
LyricsApplet (which he has already modified) or the lyrics from the other task 
(lyrics script, TagDialog etc.).

Oh, in my strings there are two placeholders:
%1 => the artist
%2 => the title

Regards,
Martin

[0] https://bugs.kde.org/show_bug.cgi?id=207621
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]