[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 117077: Extend editing transactions
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: 2014-03-26 15:25:27
Message-ID: 20140326152527.24148.66906 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117077/#review54213
-----------------------------------------------------------
src/document/katedocument.h
<https://git.reviewboard.kde.org/r/117077/#comment37915>
pedantic: should this be 'isEditingTransactionRunning'?
- Matthew Woehlke
On March 26, 2014, 6:41 a.m., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117077/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 6:41 a.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Adds
> - void KTE::Document::EditingTransaction::start()
> - void KTE::Document::EditingTransaction::finish()
> - bool KTE::Document::editingTransactionRunning() const
>
>
> Diffs
> -----
>
> src/include/ktexteditor/document.h a028be5
> src/document/katedocument.cpp 09b7db9
> src/document/katedocument.h caad6d7
> src/utils/document.cpp ed8d6a3
>
> Diff: https://git.reviewboard.kde.org/r/117077/diff/
>
>
> Testing
> -------
>
> None yet (no idea whether it compiles).
>
>
> Thanks,
>
> Dominik Haumann
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117077/">https://git.reviewboard.kde.org/r/117077/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117077/diff/1/?file=257233#file257233line183" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/document/katedocument.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">183</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">virtual</span> <span class="kt">bool</span> <span \
class="n">editingTransactionRunning</span><span class="p">()</span> <span \
class="k">const</span> <span class="n">Q_DECL_OVERRIDE</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pedantic: \
should this be 'isEditingTransactionRunning'?</pre> </div>
<br />
<p>- Matthew Woehlke</p>
<br />
<p>On March 26th, 2014, 6:41 a.m. EDT, Dominik Haumann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 6:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds
- void KTE::Document::EditingTransaction::start()
- void KTE::Document::EditingTransaction::finish()
- bool KTE::Document::editingTransactionRunning() const</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None yet (no idea whether it compiles).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/include/ktexteditor/document.h <span style="color: \
grey">(a028be5)</span></li>
<li>src/document/katedocument.cpp <span style="color: grey">(09b7db9)</span></li>
<li>src/document/katedocument.h <span style="color: grey">(caad6d7)</span></li>
<li>src/utils/document.cpp <span style="color: grey">(ed8d6a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117077/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic