'Re: Review Request 117077: Extend editing transactions'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117077: Extend editing transactions
From:       "Christoph Cullmann" <cullmann () kde ! org>
Date:       2014-03-26 11:18:23
Message-ID: 20140326111823.26294.70513 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117077/#review54173
-----------------------------------------------------------

Ship it!

Ship It!

- Christoph Cullmann

On March 26, 2014, 10:41 a.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117077/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 10:41 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Adds
> - void KTE::Document::EditingTransaction::start()
> - void KTE::Document::EditingTransaction::finish()
> - bool KTE::Document::editingTransactionRunning() const
> 
> 
> Diffs
> -----
> 
>   src/include/ktexteditor/document.h a028be5 
>   src/document/katedocument.cpp 09b7db9 
>   src/document/katedocument.h caad6d7 
>   src/utils/document.cpp ed8d6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/117077/diff/
> 
> 
> Testing
> -------
> 
> None yet (no idea whether it compiles).
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117077/">https://git.reviewboard.kde.org/r/117077/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Christoph Cullmann</p>

<br />
<p>On March 26th, 2014, 10:41 a.m. UTC, Dominik Haumann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Dominik Haumann.</div>

<p style="color: grey;"><i>Updated March 26, 2014, 10:41 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Adds
- void KTE::Document::EditingTransaction::start()
- void KTE::Document::EditingTransaction::finish()
- bool KTE::Document::editingTransactionRunning() const</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None yet (no idea whether it compiles).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/include/ktexteditor/document.h <span style="color: \
grey">(a028be5)</span></li>

 <li>src/document/katedocument.cpp <span style="color: grey">(09b7db9)</span></li>

 <li>src/document/katedocument.h <span style="color: grey">(caad6d7)</span></li>

 <li>src/utils/document.cpp <span style="color: grey">(ed8d6a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117077/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 