From kwrite-devel Wed Mar 26 15:25:27 2014 From: "Matthew Woehlke" Date: Wed, 26 Mar 2014 15:25:27 +0000 To: kwrite-devel Subject: Re: Review Request 117077: Extend editing transactions Message-Id: <20140326152527.24148.66906 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139584754318376 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2682661039360147291==" --===============2682661039360147291== Content-Type: multipart/alternative; boundary="===============4714493167246762616==" --===============4714493167246762616== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117077/#review54213 ----------------------------------------------------------- src/document/katedocument.h pedantic: should this be 'isEditingTransactionRunning'? - Matthew Woehlke On March 26, 2014, 6:41 a.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117077/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 6:41 a.m.) > > > Review request for Kate. > > > Repository: ktexteditor > > > Description > ------- > > Adds > - void KTE::Document::EditingTransaction::start() > - void KTE::Document::EditingTransaction::finish() > - bool KTE::Document::editingTransactionRunning() const > > > Diffs > ----- > > src/include/ktexteditor/document.h a028be5 > src/document/katedocument.cpp 09b7db9 > src/document/katedocument.h caad6d7 > src/utils/document.cpp ed8d6a3 > > Diff: https://git.reviewboard.kde.org/r/117077/diff/ > > > Testing > ------- > > None yet (no idea whether it compiles). > > > Thanks, > > Dominik Haumann > > --===============4714493167246762616== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117077/

src/document/katedocument.h (Diff revision 1) 
public Q_SLOTS:
 

    183
    
    virtual bool editingTransactionRunning() const Q_DECL_OVERRIDE;

  


 





pedantic: should this be 'isEditingTransactionRunning'?









- Matthew Woehlke






On March 26th, 2014, 6:41 a.m. EDT, Dominik Haumann wrote:











 

  


Review request for Kate.


By Dominik Haumann.




Updated March 26, 2014, 6:41 a.m.












 Repository: 
ktexteditor





Description 

 

 

  
   
Adds
- void KTE::Document::EditingTransaction::start()
- void KTE::Document::EditingTransaction::finish()
- bool KTE::Document::editingTransactionRunning() const

  		
 






Testing 



 

  
   
None yet (no idea whether it compiles).

  		
 






Diffs 


    

 
  • src/include/ktexteditor/document.h (a028be5)
    • 

 
  • src/document/katedocument.cpp (09b7db9)
    • 

 
  • src/document/katedocument.h (caad6d7)
    • 

 
  • src/utils/document.cpp (ed8d6a3)
    • 





View Diff








  		
 











  

 



--===============4714493167246762616==--

--===============2682661039360147291==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

--===============2682661039360147291==--